-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ledger thorchain support #5442
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2023
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
gomesalexandre
force-pushed
the
feat_unchained_addresses
branch
from
October 11, 2023 07:19
76c9599
to
05dcf60
Compare
gomesalexandre
force-pushed
the
feat_ledger_thorchain
branch
from
October 11, 2023 07:19
8ef9c07
to
2314f1e
Compare
gomesalexandre
force-pushed
the
feat_unchained_addresses
branch
from
October 11, 2023 07:26
05dcf60
to
d55a2e0
Compare
gomesalexandre
force-pushed
the
feat_ledger_thorchain
branch
from
October 11, 2023 07:26
b68309d
to
586bc2d
Compare
gomesalexandre
force-pushed
the
feat_unchained_addresses
branch
from
October 11, 2023 07:29
d55a2e0
to
46bf387
Compare
gomesalexandre
force-pushed
the
feat_ledger_thorchain
branch
5 times, most recently
from
October 11, 2023 10:16
5f973c7
to
b1e6ed2
Compare
gomesalexandre
changed the base branch from
feat_unchained_addresses
to
feat_ledger_improvements
October 11, 2023 10:16
12 tasks
gomesalexandre
force-pushed
the
feat_ledger_improvements
branch
from
October 11, 2023 18:53
d24ca84
to
06e57f7
Compare
gomesalexandre
force-pushed
the
feat_ledger_thorchain
branch
from
October 11, 2023 18:53
f6faff3
to
0263bff
Compare
gomesalexandre
force-pushed
the
feat_ledger_improvements
branch
from
October 11, 2023 19:09
06e57f7
to
01ffab2
Compare
gomesalexandre
force-pushed
the
feat_ledger_thorchain
branch
7 times, most recently
from
October 12, 2023 17:58
8ca30d2
to
fae772f
Compare
gomesalexandre
force-pushed
the
feat_ledger_thorchain
branch
from
October 18, 2023 17:48
43840d6
to
76ee91f
Compare
0xdef1cafe
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does what it says on the box - brings THORChain capabilities to the Ledger wallet option.
Pull Request Type
Issue (if applicable)
N/A
Risk
None, isolated to Ledger feature which is under flag
Testing
Engineering
Operations
Screenshots (if applicable)
https://viewblock.io/thorchain/tx/7BA6CE5884B85EE29B0ECC6485732B6CF23E752A70DD7BE6A6E06EF127E168FA
Note, the confirm step is currently throwing because of failed XHRs, but the Tx went through https://viewblock.io/thorchain/tx/FC877A9F8DC1672BA01E4129845B171BA45282525AFC3B450BAF5A8077C1DEE9