Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ledger thorchain support #5442

Merged
merged 48 commits into from
Oct 24, 2023
Merged

feat: ledger thorchain support #5442

merged 48 commits into from
Oct 24, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Oct 10, 2023

Description

Does what it says on the box - brings THORChain capabilities to the Ledger wallet option.

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A

Risk

None, isolated to Ledger feature which is under flag

Testing

  • Follow the instructions here to get the RUNE app on your Ledger
  • THORChain is available as an account to connect
  • THORChain receive address is working (and matching the native one, if Ledger has the same seed)
  • THORChain account balance is working
  • THORChain Tx history is working, including incoming Txs through ws (note, the THOR endpoints are currently having some issues, so this may not be testable currently)
  • RUNE sends are working
  • Swaps out of RUNE are working

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

  • Account
image image
  • Receive
image
  • Send
image image

https://viewblock.io/thorchain/tx/7BA6CE5884B85EE29B0ECC6485732B6CF23E752A70DD7BE6A6E06EF127E168FA

  • Swap out of RUNE
image image

Note, the confirm step is currently throwing because of failed XHRs, but the Tx went through https://viewblock.io/thorchain/tx/FC877A9F8DC1672BA01E4129845B171BA45282525AFC3B450BAF5A8077C1DEE9

Copy link
Contributor Author

gomesalexandre commented Oct 10, 2023

@gomesalexandre gomesalexandre force-pushed the feat_unchained_addresses branch from 76c9599 to 05dcf60 Compare October 11, 2023 07:19
@gomesalexandre gomesalexandre force-pushed the feat_unchained_addresses branch from 05dcf60 to d55a2e0 Compare October 11, 2023 07:26
@gomesalexandre gomesalexandre force-pushed the feat_unchained_addresses branch from d55a2e0 to 46bf387 Compare October 11, 2023 07:29
@gomesalexandre gomesalexandre force-pushed the feat_ledger_thorchain branch 5 times, most recently from 5f973c7 to b1e6ed2 Compare October 11, 2023 10:16
@gomesalexandre gomesalexandre changed the base branch from feat_unchained_addresses to feat_ledger_improvements October 11, 2023 10:16
@gomesalexandre gomesalexandre force-pushed the feat_ledger_improvements branch from d24ca84 to 06e57f7 Compare October 11, 2023 18:53
@gomesalexandre gomesalexandre force-pushed the feat_ledger_improvements branch from 06e57f7 to 01ffab2 Compare October 11, 2023 19:09
@gomesalexandre gomesalexandre force-pushed the feat_ledger_thorchain branch 7 times, most recently from 8ca30d2 to fae772f Compare October 12, 2023 17:58
Base automatically changed from feat_ledger_improvements to develop October 18, 2023 19:52
@gomesalexandre gomesalexandre marked this pull request as ready for review October 19, 2023 17:41
@gomesalexandre gomesalexandre requested a review from a team as a code owner October 19, 2023 17:41
@0xdef1cafe 0xdef1cafe enabled auto-merge (squash) October 24, 2023 20:20
@0xdef1cafe 0xdef1cafe merged commit 1564c5d into develop Oct 24, 2023
3 checks passed
@0xdef1cafe 0xdef1cafe deleted the feat_ledger_thorchain branch October 24, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants