feat: use WarningAcknowledgement component #6647

0xApotheosis · 2024-04-08T01:07:43Z

Notes for reviewer: use "Hide whitespace" when viewing the diff, and ignore the insane commit history (it was started on the old develop branch before I fixed it).

Description

Adds a new, generic, WarningAcknowledgement component that can be used across LP, Swapper, and Saver domains to provide a consistent user experience for acknowledging risks associated with a transaction.

Wires up this component for the following features/flows:

Lending borrow on unsafe quote (high slippage)
Trade quote input on unsafe quote (wired up, though I don't think we have any unsafe quote logic upstream, so this won't show for now)
Trade quote confirm on unsafe price impact/high slippage
LP deposits

Still to do (follow-up PR):

Savers withdraw (fees higher than withdrawal amount)
LP pool halted
Multi-hop trade, may end up with different asset if something goes wrong
LiFi single-hop trades with intermediary assets

Pull Request Type

🐛 Bug fix (Non-breaking Change: Fixes an issue)
🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Mostly addresses #6605, follow up PR for remaining places to come.

Risk

High. Whilst this PR should only add an additional step in unsafe transaction situations, getting it wrong could mean we break the flow entirely for all of our key revenue generating flows.

What protocols, transaction types or contract interactions might be affected by this PR?

Swaps
LP deposits
Savers borrow

Testing

Savers borrow

Use frame to quote a borrow that will result in an unsafe amount of slippage. Upon confirmation of the quote a warning should show.

Not able to test or get a screenshot at time or writing, as borrow is currently halted (cap full).

Monkey patched shot:

Trade quote input

Get a THORChain quote from ETH to BTC, enter about 0.05 ETH and the an unsafe warning should show on preview.

Trade quote confirm

Use frame to confirm a trade that has an unsafe amount of slippage. Upon confirmation of the trade a warning should show.

LP deposit

Use frame to get a quote for a large deposit that cause slippage. Upon confirmation a deposit warning should show.

Engineering

☝️

Operations

☝️

Screenshots (if applicable)

high-slippage.mp4

* add bottom sheet dialog * try out vaul * hook up send * Create SubPage.tsx * adjusting dialog header * Update DialogCloseButton.tsx * add new action menu * updates * update more height stuff * use 100dvh instead of vh * use 100vh * anchor footer at the bottom of the screen * update new asset search * Update SelectAssets.tsx * add min height for regular modals * Update MobileNavBar.tsx * remove extra stuff not needed for PR * remove more stuff not for this PR * Update AddressInput.tsx * Update AddressInput.tsx * Update Dialog.tsx * Update SelectAssets.tsx * fix for dialog height * Update AssetSearch.tsx --------- Co-authored-by: gomes <[email protected]>

* feat: use proxy validation endpoint * chore: improve fn name * update endpoint * fix: csp * fix: tests * chore: use shapeshift proxy csp * chore: fail open --------- Co-authored-by: kaladinlight <[email protected]>

* account down remove portal * Update StepRow.tsx

* chore: invalidate outdated translations * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize * Translate main.json via GitLocalize --------- Co-authored-by: Hellhound13 <[email protected]> Co-authored-by: Jpanam <[email protected]> Co-authored-by: yuki <[email protected]> Co-authored-by: guiribabrb <[email protected]> Co-authored-by: Markus Meyer <[email protected]> Co-authored-by: Romko <[email protected]> Co-authored-by: tonyjiang12399 <[email protected]>

* feat: getFullAppData tests * feat: cow quote/unsigned order build cleanup

Co-authored-by: GitHub Action <[email protected]>

* fix: zapperAssetToMaybeAssetId handle base-token as native asset * fix: filter unique opportunities by id first * Revert "fix: zapperAssetToMaybeAssetId handle base-token as native asset" This reverts commit 1ed1a59.

* feat: uni-v2 pools static generation * feat: revert DynamicLpAssets flag * feat: regen * feat: cleanup asset upserty bits * feat: regen

Update YourPositions.tsx

0xApotheosis · 2024-04-16T04:54:31Z

@gomesalexandre & @woodenfurniture all feedback addressed sers 🙏

CI currently failing for unrelated reasons (waiting for my hotfix into release to be merged back into develop).

src/pages/Lending/Pool/components/Borrow/BorrowInput.tsx

src/assets/translations/en/main.json

src/components/MultiHopTrade/components/TradeInput/TradeInput.tsx

gomesalexandre

Tackled comments look sane - retested at runtime:

Swapper styles

Looks sane again! ✅

Swapper unsafe lower than minimum

Ack is now properly triggered, and captures the original onClick event behavior ✅

unsafe.btc.mov

Swapper Confirm

Ack is properly triggered, and captures the original onClick event behavior ✅

swapper.confirm.ack.mov

Lending - high-slippage borrow

Wasn't able to retest as both pools are currently halted, though this was previously tested

THORCHain LP

Ack is properly triggered, and captures the original onClick event behavior ✅

Screen.Recording.2024-04-16.at.12.34.55.mov

src/components/WarningAcknowledgement/WarningAcknowledgement.tsx

woodenfurniture · 2024-04-16T23:27:11Z

Applying the same patch to invoke unsafe trade quote, the layout is greatly improved but is missing a description of the issue such that it just says "Attention!" without further context 😅

woodenfurniture

Fallback text now appearing. Looking good to merge

woodenfurniture and others added 22 commits April 2, 2024 19:59

Merge branch 'main' into develop

4513c3b

feat: regenerate asset data 04/02/2024 (#6620)

bd20bf0

feat: disable sym deposits after RUNE (#6622)

88ab918

fix: don't bork asset generation on idle API failures (#6619)

b1e3490

feat: collect 0x trade surplus (#6625)

ca37e0e

chore: use unchained proxy endpoints over nownodes proxy (#6606)

faa414f

feat: use proxy validation endpoint (#6626)

f1f0d1b

* feat: use proxy validation endpoint * chore: improve fn name * update endpoint * fix: csp * fix: tests * chore: use shapeshift proxy csp * chore: fail open --------- Co-authored-by: kaladinlight <[email protected]>

feat: many migrations (#6631)

ced5a38

fix: remove portal on account dropdown (#6635)

939320c

* account down remove portal * Update StepRow.tsx

feat: cow affiliate fees (#6621)

4844a2c

feat: cow quote/unsigned order build cleanup (#6639)

8967dcd

* feat: getFullAppData tests * feat: cow quote/unsigned order build cleanup

fix: deep merge opportunities accounts (#6627)

340c9fc

feat: regenerate asset data 04/04/2024 (#6636)

43db1bb

Co-authored-by: GitHub Action <[email protected]>

fix: defi aggregated opportunities uniqBy id first (#6628)

88b3612

* fix: zapperAssetToMaybeAssetId handle base-token as native asset * fix: filter unique opportunities by id first * Revert "fix: zapperAssetToMaybeAssetId handle base-token as native asset" This reverts commit 1ed1a59.

feat: lending loan summary repayment lock (#6642)

62d6160

fix: mobile dashboard routing (#6637)

ef740bb

feat: thorchain lp disable max deposits (#6645)

0bfb6ba

feat: uni-v2 pools static generation (#6629)

0da4bb9

* feat: uni-v2 pools static generation * feat: revert DynamicLpAssets flag * feat: regen * feat: cleanup asset upserty bits * feat: regen

Merge branch 'main' into develop

43fb92c

feat: regenerate asset data 04/08/2024 (#6648)

60aab31

0xApotheosis force-pushed the warning-ack branch from c9a3940 to 809d96e Compare April 9, 2024 01:41

gomesalexandre and others added 7 commits April 9, 2024 14:43

feat: thorchain LP charts (#6624)

d3f4241

feat: tag foxy as expired opportunity (#6651)

aa484a3

fix: empty my position pools page (#6656)

ddec22a

Update YourPositions.tsx

feat: add first pass WarningAcknowledgement component

8e3487b

chore: use translations

a5bc377

chore: wire up savers deposit

a77d372

chore: tidy

9651bcc

gomesalexandre and others added 8 commits April 15, 2024 10:25

fix: thor token repayments (#6676)

ff32121

fix: don't render back button on modals initial routes (#6675)

ead8c2e

chore: use translations & constants

05c292f

chore: address review feedback

916ecb4

Merge branch 'develop' into warning-ack

508d80f

fix: unbork trade widget size

66420d8

fix: show minimum trade amount when unsafe

c281c20

fix: trade confirm width

68d0ff7

0xApotheosis requested review from gomesalexandre and woodenfurniture April 16, 2024 04:54

Merge branch 'develop' into warning-ack

d1295c2

gomesalexandre reviewed Apr 16, 2024

View reviewed changes

src/pages/Lending/Pool/components/Borrow/BorrowInput.tsx Show resolved Hide resolved

gomesalexandre reviewed Apr 16, 2024

View reviewed changes

src/assets/translations/en/main.json Outdated Show resolved Hide resolved

gomesalexandre reviewed Apr 16, 2024

View reviewed changes

src/components/MultiHopTrade/components/TradeInput/TradeInput.tsx Outdated Show resolved Hide resolved

chore: trigger CI

a4d7407

gomesalexandre approved these changes Apr 16, 2024

View reviewed changes

gomesalexandre marked this pull request as ready for review April 16, 2024 08:35

fix: typo

08201d0

woodenfurniture reviewed Apr 16, 2024

View reviewed changes

src/components/WarningAcknowledgement/WarningAcknowledgement.tsx Outdated Show resolved Hide resolved

chore: extract motion style to constant

a80e329

fix: add no min fallback message

ab30e3c

woodenfurniture approved these changes Apr 16, 2024

View reviewed changes

0xApotheosis enabled auto-merge (squash) April 16, 2024 23:35

0xApotheosis disabled auto-merge April 16, 2024 23:41

0xApotheosis merged commit e6265e7 into develop Apr 16, 2024
3 checks passed

0xApotheosis deleted the warning-ack branch April 16, 2024 23:41

This was referenced Apr 16, 2024

chore: release v1.575.0 #6701

Merged

Complete WarningAcknowledgement implementation #6707

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use WarningAcknowledgement component #6647

feat: use WarningAcknowledgement component #6647

0xApotheosis commented Apr 8, 2024 •

edited

Loading

0xApotheosis commented Apr 16, 2024

gomesalexandre left a comment

woodenfurniture commented Apr 16, 2024

woodenfurniture left a comment

feat: use WarningAcknowledgement component #6647

feat: use WarningAcknowledgement component #6647

Conversation

0xApotheosis commented Apr 8, 2024 • edited Loading

Description

Pull Request Type

Issue (if applicable)

Risk

Testing

Engineering

Operations

Screenshots (if applicable)

0xApotheosis commented Apr 16, 2024

gomesalexandre left a comment

Choose a reason for hiding this comment

Swapper styles

Swapper unsafe lower than minimum

Swapper Confirm

Lending - high-slippage borrow

THORCHain LP

woodenfurniture commented Apr 16, 2024

woodenfurniture left a comment

Choose a reason for hiding this comment

0xApotheosis commented Apr 8, 2024 •

edited

Loading