Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backed sparse matrix compat with scipy 1.15 #1806

Merged
merged 8 commits into from
Dec 19, 2024
Merged

Fix backed sparse matrix compat with scipy 1.15 #1806

merged 8 commits into from
Dec 19, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Dec 19, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.60%. Comparing base (ecdcc74) to head (5cb2cb3).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1806      +/-   ##
==========================================
- Coverage   86.90%   84.60%   -2.30%     
==========================================
  Files          40       40              
  Lines        6101     6107       +6     
==========================================
- Hits         5302     5167     -135     
- Misses        799      940     +141
Files with missing lines Coverage Δ
src/anndata/_core/sparse_dataset.py 93.75% <100.00%> (+0.75%) ⬆️
src/anndata/compat/__init__.py 81.58% <100.00%> (-3.77%) ⬇️

... and 9 files with indirect coverage changes

@flying-sheep flying-sheep added this to the 0.11.2 milestone Dec 19, 2024
@flying-sheep flying-sheep changed the title Fix backed-sparse tests Fix backed sparse matrix compat with scipy 1.5 Dec 19, 2024
@flying-sheep flying-sheep marked this pull request as ready for review December 19, 2024 14:51
@flying-sheep flying-sheep changed the title Fix backed sparse matrix compat with scipy 1.5 Fix backed sparse matrix compat with scipy 1.15 Dec 19, 2024
@flying-sheep flying-sheep requested a review from Intron7 December 19, 2024 15:36
@flying-sheep flying-sheep merged commit d84a48e into main Dec 19, 2024
15 checks passed
@flying-sheep flying-sheep deleted the pa/fix-scipy-1.5 branch December 19, 2024 16:47
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Dec 19, 2024
@flying-sheep @meeseeksmachine
Backport PR scverse#1806: Fix backed sparse matrix compat with scipy …
e72b707 
…1.15
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 19, 2024
Merged
flying-sheep added a commit that referenced this pull request Dec 19, 2024
@meeseeksmachine @flying-sheep
Backport PR #1806: Fix backed sparse matrix compat with scipy 1.15 (#…
cb2154e 
…1809)

Co-authored-by: Philipp A <[email protected]>
This was referenced Jan 4, 2025
Open
Merged
This was referenced Jan 6, 2025
Closed
Closed
@jdblischak jdblischak mentioned this pull request Jan 9, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Intron7 Intron7 Awaiting requested review from Intron7

Assignees
No one assigned
Labels
skip-gpu-ci
Projects
None yet
Milestone
0.11.2
Development

Successfully merging this pull request may close these issues.

Crash on read of backed-mode X with scipy==1.15.0rc1
1 participant
@flying-sheep