fix(3181): Virtual builds not completed when triggered by webhook

[sagar1312]

Context

Changes made in the PR #3252 introduced a regression. Virtual job builds at the beginning of the event workflow never got marked as completed (remain in CREATED state) when the event is created by SCM webhook.

Objective

Mark virtual job builds at the beginning of the event workflow for all the scenarios.

References

#3181

License

I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

[coveralls]

coverage: 95.336% (+0.007%) from 95.329%
when pulling 5448a07 on fix-3181-virtual_job_by_webhook
into 696ce8c on master.

[jithine]

Is this a duplicate of #3260

[sagar1312]

Is this a duplicate of #3260

Yes, #3260 can be closed. Moved the logic to mark virtual builds as "SUCCESS" to a common module and use it wherever needed.

[VonnyJap]

Suggested change

	for (const build of virtualJobBuilds) {
	await updateBuildAndTriggerDownstreamJobs(
	{
	status: Status.SUCCESS,
	statusMessage: BUILD_STATUS_MESSAGES.SKIP_VIRTUAL_JOB.statusMessage,
	statusMessageType: BUILD_STATUS_MESSAGES.SKIP_VIRTUAL_JOB.statusMessageType
	},
	build,
	server,
	username,
	scmContext
	);
	}
	await Promise.all(
	virtualJobBuilds.map(build =>
	updateBuildAndTriggerDownstreamJobs(
	{
	status: Status.SUCCESS,
	statusMessage: BUILD_STATUS_MESSAGES.SKIP_VIRTUAL_JOB.statusMessage,
	statusMessageType: BUILD_STATUS_MESSAGES.SKIP_VIRTUAL_JOB.statusMessageType
	},
	build,
	server,
	username,
	scmContext
	)
	)
	);

[sagar1312]

Besides marking the status of virtual build to "SUCCESS", we also process its downstream jobs. While triggering the downstream jobs in the workflow, we have been following depth-first approach. Sticking to the same here as well.
So we need process all the virtual builds sequentially.