-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(3181): virtual job is not triggered by webhook #3260
fix(3181): virtual job is not triggered by webhook #3260
Conversation
plugins/webhooks/helper.js
Outdated
`Failed to pullRequestOpened: [${hookId}, pipeline:${options.pipeline && options.pipeline.id}]: ${err}` | ||
); | ||
for (const event of hasBuildEvents) { | ||
const virtualJobBuilds = event.builds.filter(b => b.status === 'CREATED'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a more explicit check that can be used on the build/job to denote that it's a virtual Job Build ?
Would there be any other scenario for CREATED
build status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I fixed.
Thank you. I'll close this PR. |
Context
Virtual job builds are not triggered directly by webhook.
After screwdriver-cd/models#635, the virtual job builds are not triggered in
eventFactory
, so we should trigger them other place.Objective
Trigger the virtual job builds in webhook process.
References
Issue
PR
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.