Client overhaul to match server routes #73
Conversation
launch/client.py
Outdated
| gpu_type=gpu_type, | ||
| default_callback_url=default_callback_url, | ||
| ) | ||
| return json.loads(response.resopnse.data) |
| query_params=query_params, | ||
| skip_deserialization=True, | ||
| ) | ||
| return response |
There was a problem hiding this comment.
I skipped deserialization because there are sometimes inconsistencies between return types and the auto-generated response types. They're finicky sometimes and imo the extra typing we get isn't worth the hassle.
There was a problem hiding this comment.
I think wrapping purely around the REST APIs does make more sense, but I'm wondering what would make the most sense for releasing to users. We made the migration to v1 REST API routes relatively painless for users by maintaining pretty much the same Python API, and I wonder if we would want to be a bit less aggressive and simply decorate the old Python API as @deprecated and unsupported in a few minor releases.
Yup those are my thoughts too - mark the existing functions as |
No description provided.