Use endpoint IDs for endpoint predict requests #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1187,7 +1185,6 @@ def _async_request( | |||
| `abcabcab-cabc-abca-0123456789ab` | |||
| """ | |||
| validate_task_request(url=url, args=args) | |||
| endpoint = self.get_model_endpoint(endpoint_name) | |||
There was a problem hiding this comment.
is this just a postgres call?
There was a problem hiding this comment.
Yes, but also Redis to get some cached data about the infra state (and k8s api server if Redis cache doesn't contain the info)
yunfeng-scale
approved these changes
Feb 15, 2023
yixu34
reviewed
Feb 15, 2023
Sort of? |
True, though I think enough people might have latched onto Maybe we can do a broader change as part of #73? |
|
Ok closing this in favor of modifying #73 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra latency right now for sync/async requests incurred from querying for endpoint by name