Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename module and update mirrors (gh issue #98). #102

Merged
merged 2 commits into from
Dec 23, 2016
Merged

Rename module and update mirrors (gh issue #98). #102

merged 2 commits into from
Dec 23, 2016

Conversation

CFGrote
Copy link
Collaborator

@CFGrote CFGrote commented Dec 16, 2016

Please review changes and merge.

@CFGrote CFGrote closed this Dec 16, 2016
@CFGrote CFGrote reopened this Dec 16, 2016
@CFGrote CFGrote mentioned this pull request Dec 21, 2016
Closed
@buzmakov
Copy link
Collaborator

buzmakov commented Dec 23, 2016 •
edited
Loading

@samoylv Have you look on it?
For me looks fine, but I don't test it.

@samoylv
Copy link
Owner

samoylv commented Dec 23, 2016

Looks fine for me too. Maybe we can merge and test?

@buzmakov buzmakov merged commit cebedfe into develop Dec 23, 2016
@buzmakov
Copy link
Collaborator

Done

@buzmakov
Copy link
Collaborator

We defenetly should add test to run prop in our tests.
See #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buzmakov buzmakov Awaiting requested review from buzmakov

@samoylv samoylv Awaiting requested review from samoylv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CFGrote @buzmakov @samoylv