Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review prop beamlines #98

Closed
buzmakov opened this issue Dec 8, 2016 · 3 comments
Closed

Review prop beamlines #98

buzmakov opened this issue Dec 8, 2016 · 3 comments
Assignees

Comments

@buzmakov
Copy link
Collaborator

buzmakov commented Dec 8, 2016

Try to separate S2E and day1

@samoylv
Copy link
Owner

samoylv commented Dec 16, 2016

  1. i.e. rename beamlines
  2. spb kb beamline: update elliptical mirror propagators (now in in my_s2e_beamline.py), should be:
    hfm    = wpg.optical_elements.Mirror_elliptical(
                    orient='x',
                    p=distance, 
                    q=(distance_hfm_vfm+distance_foc), 
                    thetaE=theta_kb,
                    theta0=theta_kb,
                    length=0.9 
                    )     
    vfm    = wpg.optical_elements.Mirror_elliptical(
                    orient='y',
                    p=(distance+distance_hfm_vfm), 
                    q=distance_foc, 
                    thetaE=theta_kb,
                    theta0=theta_kb,
                    length=0.9 
                    )     

@CFGrote CFGrote self-assigned this Dec 16, 2016
@CFGrote
Copy link
Collaborator

CFGrote commented Dec 16, 2016

Done in branch update_prop_beamlines

@CFGrote
Copy link
Collaborator

CFGrote commented Dec 21, 2016

See pull request #102

buzmakov added a commit that referenced this issue Dec 23, 2016
Rename module and update mirrors (gh issue #98).
@samoylv samoylv closed this as completed Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants