SALTO-6995: Add element-test-utils package #6866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamtamirr
reviewed
Dec 1, 2024
packages/adapter-api/test/setup.ts
Outdated
Comment on lines
12
to
19
| // We cannot import this from @salto-io/element-test-utils because it would cause a cyclic dependency | ||
| // so we have to define this here separately | ||
| export const isEqualElemID: Tester = (a, b) => { | ||
| if (a instanceof ElemID && b instanceof ElemID) { | ||
| return a.isEqual(b) | ||
| } | ||
| return undefined | ||
| } |
There was a problem hiding this comment.
- Do we a have future ticket to separate the types from
adapter-apito another package in order to break this cycle? - Is there any way to enforce having all the matchers from
elements-test-utilshere?
There was a problem hiding this comment.
I can't think of any way that would allow this given that this code requires the class (for instanceof, for calling isEqual, etc...).
AFAICT there is no way to break the cycle, because the whole point of this new package is that it can use things from adapter-api (unlike the general test-utils).
|
|
||
| --- | ||
|
|
||
| This package contains a few useful shortcuts and utilities for the [jest framework](https://jestjs.io/) |
There was a problem hiding this comment.
I think we should write a simple conventions guide about how to add matchers to this package.
ori-moisis
force-pushed
the
feature/add_element_test_utils
branch
from
71a9160 to
25d9f5f
Compare
The first thing this package implements is an override for jest expect that compares element IDs using a custom matcher
ori-moisis
force-pushed
the
feature/add_element_test_utils
branch
from
25d9f5f to
1fe4aaf
Compare
tamtamirr
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first thing this package implements is an override for jest expect that compares element IDs using a custom matcher
Additional context for reviewer
Required for #6862
Release Notes:
None
User Notifications:
None