SALTO-6991: create element ID full name only if needed #6862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omrilit
approved these changes
Nov 28, 2024
ori-moisis
force-pushed
the
perf/elem_id_skip_creating_fullname
branch
2 times, most recently
from
46a5f6e to
4d516e5
Compare
ori-moisis
force-pushed
the
perf/elem_id_skip_creating_fullname
branch
from
4d516e5 to
55b57e1
Compare
Before this change, the string with the full name of the element ID was always created even if it was never used Changed this to create the string the first time it is needed.
ori-moisis
force-pushed
the
perf/elem_id_skip_creating_fullname
branch
from
55b57e1 to
b51fa67
Compare
ori-moisis
added a commit
that referenced
this pull request
Dec 3, 2024
This reverts commit 1958121.
ori-moisis
added a commit
that referenced
this pull request
Dec 3, 2024
ori-moisis
added a commit
to ori-moisis/salto
that referenced
this pull request
Dec 4, 2024
salto-io#6862)" (salto-io#6888)" This reverts commit 6d2bce9.
ori-moisis
added a commit
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the string with the full name of the element ID was always created even if it was never used Changed this to create the string the first time it is needed.
Additional context for reviewer
Tested this with a dummy adapter fetch that created a very large number of detailed changes.
This change reduced peak memory consumption from ~7.9GB to 6.9GB
Based on #6866 and #6880
Release Notes:
Core:
User Notifications:
None