Release 1.48.0

.env.example

@@ -2,10 +2,16 @@
 NEXT_PUBLIC_INFURA_TOKEN=
 NEXT_PUBLIC_SAFE_APPS_INFURA_TOKEN=
 
+# WalletConnect
+NEXT_PUBLIC_WC_PROJECT_ID=
+
 ## CGW
 NEXT_PUBLIC_GATEWAY_URL_PRODUCTION=
 NEXT_PUBLIC_GATEWAY_URL_STAGING=
 
+# Blockaid
+NEXT_PUBLIC_BLOCKAID_CLIENT_ID=
+
 # Transaction simulation
 NEXT_PUBLIC_TENDERLY_SIMULATE_ENDPOINT_URL=
 NEXT_PUBLIC_TENDERLY_PROJECT_NAME=
@@ -17,15 +23,11 @@ NEXT_PUBLIC_IS_PRODUCTION=
 # Latest supported safe version, used for upgrade prompts
 NEXT_PUBLIC_SAFE_VERSION=
 
-# Access keys
+# Sentry
 NEXT_PUBLIC_SENTRY_DSN=
-NEXT_PUBLIC_BEAMER_ID=
-
-# Wallet-specific variables
-NEXT_PUBLIC_WC_PROJECT_ID=
 
-# E2E tests
-NEXT_PUBLIC_CYPRESS_MNEMONIC=
+# Beamer
+NEXT_PUBLIC_BEAMER_ID=
 
 # Safe Gelato relay service
 NEXT_PUBLIC_SAFE_GELATO_RELAY_SERVICE_URL_PRODUCTION=
@@ -34,19 +36,11 @@ NEXT_PUBLIC_SAFE_GELATO_RELAY_SERVICE_URL_STAGING=
 # Firebase Cloud Messaging
 NEXT_PUBLIC_FIREBASE_OPTIONS_PRODUCTION=
 NEXT_PUBLIC_FIREBASE_VAPID_KEY_PRODUCTION=
-
 NEXT_PUBLIC_FIREBASE_OPTIONS_STAGING=
 NEXT_PUBLIC_FIREBASE_VAPID_KEY_STAGING=
 
-# Blockaid
-NEXT_PUBLIC_BLOCKAID_CLIENT_ID
-
-# Social Login
-NEXT_PUBLIC_SOCIAL_WALLET_OPTIONS_STAGING=
-NEXT_PUBLIC_SOCIAL_WALLET_OPTIONS_PRODUCTION=
-
 # Cypress wallet private keys
 CYPRESS_WALLET_CREDENTIALS=
 
 # [optional] Beamer keys for e2e tests
-BEAMER_DATA_E2E=
+BEAMER_DATA_E2E=

.github/workflows/code-review-gpt.yml

@@ -0,0 +1,32 @@
+name: AI code review
+
+permissions:
+  contents: read
+  pull-requests: write
+
+on:
+  pull_request:
+    types: [opened]
+
+jobs:
+  review:
+    # Don't run on draft PRs
+    if: ${{ github.event.pull_request.draft == false }}
+    runs-on: ubuntu-latest
+    steps:
+      - uses: anc95/ChatGPT-CodeReview@main
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
+          # Optional
+          MODEL: gpt-4o # https://platform.openai.com/docs/models
+          PROMPT: |
+            Review the code changes in this pull request with the following guidelines:
+            1.	Focus on Issues: Only highlight potential problems, such as logical errors, violations of best practices, or opportunities for improvement. Avoid commenting on existing code unless directly impacted by the changes.
+            2.	Skip Politeness: Provide feedback directly and concisely, without unnecessary niceties.
+            3.	No Praise: Avoid commenting on what’s done well or works correctly unless necessary for context.
+            4.	Actionable Suggestions: Offer specific, actionable recommendations for refactoring or fixes where applicable.
+            5.  Refactoring Ideas: Pay attention to the code structure and suggest improvements where necessary. Apply the DRY and SOLID principles. Prevent too complex components, inline functions, inline styles, and too much logic inside React components.
+            6.	Stay Brief: If no clear issues are identified or the concerns are minor, keep feedback minimal or state that no significant issues were found.
+
+            Output should be focused, practical, and devoid of redundant commentary. Stick to 260 characters per comment.

.github/workflows/cypress/action.yml

@@ -38,9 +38,9 @@ runs:
         curl -O 'https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb'
         sudo apt-get install ./google-chrome-stable_current_amd64.deb
 
-    - name: Install Cypress 13.13.1
+    - name: Install Cypress 13.15.2
       shell: bash
-      run: npm install cypress@13.13.1 --legacy-peer-deps
+      run: yarn add -D cypress@13.15.2
 
     - uses: ./.github/workflows/build
       with:

.github/workflows/e2e-full-ondemand.yml

@@ -12,7 +12,7 @@ concurrency:
 jobs:
   e2e:
     runs-on: ubuntu-20.04
-    timeout-minutes: 40
+    timeout-minutes: 90
     name: Cypress Full Regression on demand tests
     strategy:
       fail-fast: false

.github/workflows/e2e-ondemand.yml

@@ -10,7 +10,7 @@ concurrency:
 jobs:
   e2e:
     runs-on: ubuntu-20.04
-    timeout-minutes: 40
+    timeout-minutes: 90
     name: Cypress Regression on demand tests
     strategy:
       fail-fast: false

.github/workflows/lint.yml

@@ -18,10 +18,11 @@ jobs:
 
       - uses: ./.github/workflows/yarn
 
-      - uses: CatChen/eslint-suggestion-action@v2
+      - uses: CatChen/eslint-suggestion-action@v4.1.7
         with:
           request-changes: true # optional
           fail-check: true # optional
           github-token: ${{ secrets.GITHUB_TOKEN }} # optional
           directory: './' # optional
           targets: 'src' # optional
+          config-path: './eslint.config.mjs'

cypress.config.js

@@ -67,6 +67,7 @@ export default defineConfig({
     hideXHR: true,
     defaultCommandTimeout: 10000,
     pageLoadTimeout: 60000,
+    numTestsKeptInMemory: 20,
   },
 
   chromeWebSecurity: false,

cypress/e2e/happypath/recovery_hp_1.cy.js

@@ -34,13 +34,7 @@ describe('Recovery happy path tests 1', () => {
     recovery.clickOnNextBtn()
     tx.executeFlow_1()
     recovery.verifyRecovererAdded([constants.SEPOLIA_OWNER_2_SHORT])
-
     recovery.clearRecoverers()
-
-    // recovery.removeRecoverer(0, constants.SEPOLIA_OWNER_2)
-    // recovery.clickOnNextBtn()
-    // tx.executeFlow_1()
-
     recovery.getSetupRecoveryBtn()
   })
 })

cypress/e2e/happypath/recovery_hp_4.cy.js

@@ -0,0 +1,42 @@
+import * as constants from '../../support/constants.js'
+import * as main from '../pages/main.page.js'
+import * as owner from '../pages/owners.pages.js'
+import * as recovery from '../pages/recovery.pages.js'
+import * as tx from '../pages/transactions.page.js'
+import { getSafes, CATEGORIES } from '../../support/safes/safesHandler.js'
+import * as wallet from '../../support/utils/wallet.js'
+
+let recoverySafes = []
+const walletCredentials = JSON.parse(Cypress.env('CYPRESS_WALLET_CREDENTIALS'))
+const signer = walletCredentials.OWNER_4_PRIVATE_KEY
+
+describe('Recovery happy path tests 4', () => {
+  before(async () => {
+    recoverySafes = await getSafes(CATEGORIES.recovery)
+  })
+
+  beforeEach(() => {
+    cy.visit(constants.securityUrl + recoverySafes.SEP_RECOVERY_SAFE_5)
+    cy.clearLocalStorage()
+    main.acceptCookies()
+  })
+
+  // Check that recovery can be setup and removed from modules
+  it('Recovery setup happy path 4', () => {
+    wallet.connectSigner(signer)
+    owner.waitForConnectionStatus()
+    recovery.clearRecoverers()
+    recovery.clickOnSetupRecoveryBtn()
+    recovery.clickOnSetupRecoveryModalBtn()
+    recovery.clickOnNextBtn()
+    recovery.enterRecovererAddress(constants.SEPOLIA_OWNER_2)
+    recovery.agreeToTerms()
+    recovery.clickOnNextBtn()
+    tx.executeFlow_1()
+    recovery.verifyRecovererAdded([constants.SEPOLIA_OWNER_2_SHORT])
+    cy.visit(constants.modulesUrl + recoverySafes.SEP_RECOVERY_SAFE_5)
+    recovery.deleteRecoveryModule()
+    cy.visit(constants.securityUrl + recoverySafes.SEP_RECOVERY_SAFE_5)
+    recovery.getSetupRecoveryBtn()
+  })
+})

cypress/e2e/happypath_2/proposers.cy.js

@@ -0,0 +1,51 @@
+import * as constants from '../../support/constants.js'
+import * as owner from '../pages/owners.pages.js'
+import { getSafes, CATEGORIES } from '../../support/safes/safesHandler.js'
+import * as wallet from '../../support/utils/wallet.js'
+import * as proposer from '../pages/proposers.pages.js'
+
+let staticSafes = []
+const walletCredentials = JSON.parse(Cypress.env('CYPRESS_WALLET_CREDENTIALS'))
+const signer = walletCredentials.OWNER_4_PRIVATE_KEY
+const signer3 = walletCredentials.OWNER_3_PRIVATE_KEY
+const addedProposer = walletCredentials.OWNER_3_WALLET_ADDRESS
+const proposerAddress = 'sep:0xC16D...6fED'
+const proposerAddress2 = '0x8eeC...2a3b'
+const proposerName2 = 'Proposer 2'
+const proposerName = 'Proposer 1'
+const changedProposerName = 'Changed proposer name'
+
+describe('Happy path Proposers tests', () => {
+  before(async () => {
+    staticSafes = await getSafes(CATEGORIES.static)
+  })
+
+  //TODO: Flaky due to UI retrieval issue - wip
+  it.skip('Verify that editing a proposer is only possible for the proposer created by the creator', () => {
+    cy.visit(constants.setupUrl + staticSafes.SEP_STATIC_SAFE_31)
+    wallet.connectSigner(signer3)
+    cy.contains(owner.safeAccountNonceStr, { timeout: 10000 })
+    proposer.verifyEditProposerBtnDisabled(proposerAddress)
+
+    proposer.clickOnEditProposerBtn(proposerAddress2)
+    proposer.enterProposerName(changedProposerName)
+    proposer.clickOnSubmitProposerBtn()
+    proposer.checkProposerData([changedProposerName])
+
+    proposer.clickOnEditProposerBtn(proposerAddress2)
+    proposer.enterProposerName(proposerName2)
+    proposer.clickOnSubmitProposerBtn()
+    proposer.checkProposerData([proposerName2])
+  })
+
+  it('Verify a proposer can be added', () => {
+    cy.visit(constants.setupUrl + staticSafes.SEP_STATIC_SAFE_32)
+    wallet.connectSigner(signer)
+    cy.contains(owner.safeAccountNonceStr, { timeout: 10000 })
+    proposer.deleteAllProposers()
+    proposer.clickOnAddProposerBtn()
+    proposer.enterProposerData(addedProposer, proposerName)
+    proposer.clickOnSubmitProposerBtn()
+    proposer.verifyProposerSuccessMsgDisplayed()
+  })
+})