Release 1.48.0 #4667
Merged
Release 1.48.0 #4667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: update to nextjs 15 * chore: fix tsc lint errors * chore: fix eslint errors * chore: fixing failing unit tests * chore: remove yarn * chore: update eslint to v9 * chore: update github eslint action * chore: update cypress to v13.15.2 (#4490) * chore: update cypress to v13.15.2 * chore: update cypress github action to use v13.15.2 * chore: update mui to v6 (#4499) * chore: update mui to v6 Applied codemons to update the code * refactor: fix DatePicker with mui v6 fix: failing Date test * refactor: use ListItemButton instead of ListItem the selected and disabled props on ListItem have been removed in v6, but are available on the ListItemButton * chore: update snapshots * refactor: recoveryModal tests use snapshots * fix: failing bookmarks test with mui v6 * fix: missing DM-Sans font * fix: drawer was stealing clicks from rest of page * fix: failing tests * fix: fonts fail to load Read the comment in the file and have fun! * fix: prettier errors * fix: tsc errors
* Fix: mui accordion background * Update tests
* Fix: remove old app store button * Rm import
* Chore: replace @WalletConnect packages with @reown/walletkit * Fix tests * Add core
* fix: fetch safe overviews including untrusted token fiatTotal * test: fix safeOverviews.test.ts * chore: add comment explaining why trusted needs to be false
Bumps [ethers](https://github.com/ethers-io/ethers.js) from 6.11.1 to 6.13.4. - [Release notes](https://github.com/ethers-io/ethers.js/releases) - [Changelog](https://github.com/ethers-io/ethers.js/blob/main/CHANGELOG.md) - [Commits](ethers-io/ethers.js@v6.11.1...v6.13.4) --- updated-dependencies: - dependency-name: ethers dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Feat(Sidebar): Add pinned safes list to sidebar and accounts page [SW-304] (#4412) * feat: allow pinning and unpinning accounts * feat: allow pinning multichain safes * fix: pinning of multichain safes * feat: simplify all accounts list * feat: load safe info when safelist item is scrolled into view * feat: remove safes when unpinning if they werent added before being pinned * fix: pinning behaviour of multichain safes * fix: multichain sub itemstyles * feat: add empty state for pinned list * fix: lint errors * fix: show threshold for counterfactual safes * fix: mobile layout * restore loading balances for safes * fix: subaccount item layout, and app crashing on unpin * feat: expand all accounts if there are no pinned safes * fix: flickering when loading all safes * fix: account for default threshold and owner numbers * reduce transition animation duration for pinning and unpinning safes * reduce space between chains and balance * Feat(sidebar): sort safes by name and recently used [SW-307] (#4458) * Feat: add option to sort by recently visited and by name * tests: add new properties to unit tests * fix: make order by preference persist * feat: sort sub account items by name and recently visited * refactor: fix incorrect variable names and remove console log * Feat(sidebar): filter safes by search query [SW-305] (#4484) * feat: filter safes by search query * feat: display current order by option. fix text colors * feat: search by adddress name and chain name * fix: use ignoreLocation to match the final address characters when searching * add tracking event for search * fix: cypress tests * Feat(sidebar): Add tracking events for search, sorting, and pinning/unpinning safes [SW-308] (#4500) * track the number of pined safes on the accounts page * feat: track pinning, unpinning, and sorting * fix: separate watchlist and pined safes for tracking * fix: remove wallet from dependency array * Update src/components/welcome/MyAccounts/useTrackedSafesCount.ts Co-authored-by: Usame Algan <[email protected]> * fix: lint --------- Co-authored-by: Usame Algan <[email protected]> * Refactor(Sidebar): use feature directory structure for MyAccounts (#4508) * refactor: move myAccounts to features * fix:align queue and status chips with address for large screens * remove commented code * fix: chip styles * fix(sidebar): fix designs for data widget and empty/disconnected state [SW-507] (#4509) * fix: add connect wallet button and empty state * fix: datawidget styles * Fix(Sidebar): Include sub safe in search results [SW-305] (#4527) * fix: CF chip dark mode color * include multichain sub safe names in search * fix: queue chips being cut off * Fix: rm Remove option * Refactor: pinned = added safes [SW-304] (#4552) * Refactor: pinned = added safes * Rm Watchlist word * Fix duplicate cf safes --------- Co-authored-by: Usame Algan <[email protected]> Co-authored-by: katspaugh <[email protected]> Co-authored-by: katspaugh <[email protected]>
* fix: Disable transaction buttons until sdk is initialized * fix: Failing tests * fix: Add test case and adjust other tests to use getByText --------- Co-authored-by: katspaugh <[email protected]>
* Refactor: rm unnecessary tx decoding * Update tests * Repropose after sign relayed * Update SDK type * Update src/components/tx/confirmation-views/index.tsx Co-authored-by: Usame Algan <[email protected]> * Fix Order type * Make 420 more random --------- Co-authored-by: Usame Algan <[email protected]>
Bumps [next](https://github.com/vercel/next.js) from 15.0.4 to 15.1.0. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v15.0.4...v15.1.0) --- updated-dependencies: - dependency-name: next dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@svgr/webpack](https://github.com/gregberge/svgr) from 6.5.1 to 8.1.0. - [Release notes](https://github.com/gregberge/svgr/releases) - [Changelog](https://github.com/gregberge/svgr/blob/main/CHANGELOG.md) - [Commits](gregberge/svgr@v6.5.1...v8.1.0) --- updated-dependencies: - dependency-name: "@svgr/webpack" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@web3-onboard/coinbase](https://github.com/blocknative/web3-onboard/tree/HEAD/packages/coinbase) from 2.2.6 to 2.4.1. - [Release notes](https://github.com/blocknative/web3-onboard/releases) - [Commits](https://github.com/blocknative/web3-onboard/commits/HEAD/packages/coinbase) --- updated-dependencies: - dependency-name: "@web3-onboard/coinbase" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: CheckWallet sdk only if safe is also loaded * fix: Failing test and add another one
Branch preview✅ Deploy successful! Website: Storybook: |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1712 tests passing in 232 suites. Report generated by 🧪jest coverage report action from b942226 |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
* fix: show featured Safe Apps first on dashboard * fix: add test coverage * fix: only return featured/pinned Safe Apps * Remove unnecessary test
usame-algan
approved these changes
Dec 16, 2024
|
|
3 tasks
There is a ticket where we changed signer/signers depending on if there was more than 1 signer.
|
* fix: Cap max expiry for setTimeout in useIsExpiredSwap * refactor: Extract logic and remove Math.abs
|
we are working on the https://www.notion.so/safe-global/Ledger-Off-chain-messages-signing-with-Ledger-wrong-messages-and-2-requests-15f8180fe57380aba736d75c03533055?pvs=4 to include the Ledger update in the release |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Refactoring
Bug fixes
wallet_getCallsStatusspec. (fix: updatewallet_getCallsStatusspec. #4569)Chores
Tests