Feat: transaction note from tx origin #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Null -> undefined
PooyaRaki
reviewed
Dec 27, 2024
src/routes/transactions/entities/transaction-details/transaction-details.entity.ts
Outdated
Show resolved
Hide resolved
PooyaRaki
reviewed
Dec 27, 2024
src/routes/transactions/mappers/multisig-transactions/multisig-transaction-note.mapper.spec.ts
Outdated
Show resolved
Hide resolved
PooyaRaki
reviewed
Dec 27, 2024
src/routes/transactions/mappers/multisig-transactions/multisig-transaction-note.mapper.ts
Outdated
Show resolved
Hide resolved
PooyaRaki
reviewed
Dec 27, 2024
src/routes/transactions/mappers/multisig-transactions/multisig-transaction-note.mapper.ts
Outdated
Show resolved
Hide resolved
PooyaRaki
reviewed
Dec 27, 2024
src/routes/transactions/mappers/multisig-transactions/multisig-transaction-note.mapper.ts
Outdated
Show resolved
Hide resolved
PooyaRaki
reviewed
Dec 30, 2024
src/routes/transactions/mappers/multisig-transactions/multisig-transaction-note.mapper.spec.ts
Outdated
Show resolved
Hide resolved
PooyaRaki
approved these changes
Dec 30, 2024
|
Thanks @PooyaRaki! I'll now merge it so that we can test it on staging together with the linked frontend PR. |
PooyaRaki
approved these changes
Dec 30, 2024
|
It works! 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the decoding of multi-sig transaction notes from the transaction-service's
originfield.Needed for safe-global/safe-wallet-monorepo#4693
Changes
originstring and extracts a note from itTransactionDetailspropertynotethat is sent to the client (optional prop)