Undefined -> null

src/routes/transactions/__tests__/controllers/get-transaction-by-id.transactions.controller.spec.ts

@@ -271,6 +271,7 @@ describe('Get by id - Transactions Controller (Unit)', () => {
           },
           txHash: moduleTransaction.transactionHash,
           safeAppInfo: null,
+          note: null,
         });
       });
   });
@@ -371,6 +372,7 @@ describe('Get by id - Transactions Controller (Unit)', () => {
           detailedExecutionInfo: null,
           txHash: transfer.transactionHash,
           safeAppInfo: null,
+          note: null,
         });
       });
   });

src/routes/transactions/entities/transaction-details/transaction-details.entity.ts

@@ -47,5 +47,5 @@ export class TransactionDetails {
   @ApiPropertyOptional({ type: SafeAppInfo, nullable: true })
   safeAppInfo!: SafeAppInfo | null;
   @ApiPropertyOptional({ type: String, nullable: true })
-  note?: string;
+  note!: string | null;
 }

src/routes/transactions/mappers/module-transactions/module-transaction-details.mapper.spec.ts

@@ -80,6 +80,7 @@ describe('ModuleTransactionDetails mapper (Unit)', () => {
       txHash: transaction.transactionHash,
       detailedExecutionInfo: new ModuleExecutionDetails(addressInfo),
       safeAppInfo: null,
+      note: null,
     });
   });
 
@@ -127,6 +128,7 @@ describe('ModuleTransactionDetails mapper (Unit)', () => {
       txHash: transaction.transactionHash,
       detailedExecutionInfo: new ModuleExecutionDetails(addressInfo),
       safeAppInfo: null,
+      note: null,
     });
   });
 });

src/routes/transactions/mappers/module-transactions/module-transaction-details.mapper.ts

@@ -44,6 +44,7 @@ export class ModuleTransactionDetailsMapper {
       txHash: transaction.transactionHash,
       detailedExecutionInfo: new ModuleExecutionDetails(moduleAddress),
       safeAppInfo: null,
+      note: null,
     };
   }
 

src/routes/transactions/mappers/multisig-transactions/multisig-transaction-note.mapper.spec.ts

@@ -26,7 +26,7 @@ describe('Multisig Transaction note mapper (Unit)', () => {
 
     const note = mapper.mapTxNote(transaction);
 
-    expect(note).toBeUndefined();
+    expect(note).toBeNull();
   });
 
   it('should return undefined if `origin` does not contain a note', () => {
@@ -36,7 +36,7 @@ describe('Multisig Transaction note mapper (Unit)', () => {
 
     const note = mapper.mapTxNote(transaction);
 
-    expect(note).toBeUndefined();
+    expect(note).toBeNull();
   });
 
   it('should return undefined if `origin` is null', () => {
@@ -46,6 +46,6 @@ describe('Multisig Transaction note mapper (Unit)', () => {
 
     const note = mapper.mapTxNote(transaction);
 
-    expect(note).toBeUndefined();
+    expect(note).toBeNull();
   });
 });

src/routes/transactions/mappers/multisig-transactions/multisig-transaction-note.mapper.ts

@@ -3,7 +3,7 @@ import { MultisigTransaction } from '@/domain/safe/entities/multisig-transaction
 
 @Injectable()
 export class MultisigTransactionNoteMapper {
-  mapTxNote(transaction: MultisigTransaction): string | undefined {
+  mapTxNote(transaction: MultisigTransaction): string | null {
     if (transaction.origin) {
       try {
         const origin = JSON.parse(transaction.origin);
@@ -15,5 +15,6 @@ export class MultisigTransactionNoteMapper {
         // Ignore, no note
       }
     }
+    return null;
   }
 }

src/routes/transactions/mappers/transfers/transfer-details.mapper.spec.ts

@@ -36,6 +36,7 @@ describe('TransferDetails mapper (Unit)', () => {
       detailedExecutionInfo: null,
       txHash: transfer.transactionHash,
       safeAppInfo: null,
+      note: null,
     });
   });
 });

src/routes/transactions/mappers/transfers/transfer-details.mapper.ts

@@ -32,6 +32,7 @@ export class TransferDetailsMapper {
       detailedExecutionInfo: null,
       txHash: transfer.transactionHash,
       safeAppInfo: null,
+      note: null,
     };
   }
 }