Feat: Added "My Cases" dropdown for volunteers #5272
Conversation
Rafael-Martins
requested review from
compwron,
FireLemons and
littleforest
as code owners
|
Fixing the tests |
There was a problem hiding this comment.
- Nice work fixing the arrow behavior 👍.
- I saw you added the banners link for admins or supervisor. I believe it would be great to:
- Either Handle this in a separate issue
- Or create an issue and attach that here, it helps in keeping track of the changes.
- Lastly, this is a new feature for volunteers. Please add a couple of test cases to validate this feature.
- Thanks and great work ❤️
app/views/layouts/_sidebar.html.erb
Outdated
| </span> | ||
| <span class="text"><%= cases_index_title %></span> | ||
| </a> | ||
| <ul id="ddmenu_cases" class="collapse dropdown-nav"> |
There was a problem hiding this comment.
It would be great to extract this ul into a partial and use that in both My Cases and Casa Contacts
|
@chahmedejaz Oh, sorry about the banner, I messed with my diff, it's related to this pr: #5257, I just removed the changes from this pr! |
app/views/layouts/_sidebar.html.erb
Outdated
| <%= cases_index_title %> | ||
| <% end %> | ||
|
|
||
| <% if policy(:application).see_banner_page? %> |
There was a problem hiding this comment.
@Rafael-Martins - Sorry, seems like you mistakenly moved banner changes here 😅
There was a problem hiding this comment.
Yes I did hahaha, Already fixed!
I also createad the partial, made it show dropdown only for volunteer and fixed/added a test to cover the new dropdown!
app/views/layouts/_sidebar.html.erb
Outdated
| <% end %> | ||
| </li> | ||
|
|
||
| <% if !policy(Volunteer).index? %> |
There was a problem hiding this comment.
@Rafael-Martins - That's a good catch. Please leverage the user's role checking methods here i.e.
<% if current_user.volunteer? %>:
Lines 60 to 70 in 8f08a6a
There was a problem hiding this comment.
yeah, I was thinking in something like this, thanks!
app/views/layouts/_sidebar.html.erb
Outdated
| </li> | ||
| <% end %> | ||
|
|
||
| <% if policy(Volunteer).index? %> |
There was a problem hiding this comment.
Same can be applied here accordingly
|
There are gonna be merge conflicts here between this and #5086. I can clean them up depending on the order they are merged. |
|
The links in the sidebar lead to the casa case edit page. Volunteers aren't allowed to edit the case. Could you redirect them to the casa case details page? It's the same as the edit page but with more features for volunteers. |
Changed the link and also the test, just not sure if the failing test in the ci is related to the changes. @FireLemons |
There was a problem hiding this comment.
This name could be more specific, since it's not for all dropdowns in the sidebar, but instead for the my_cases dropdown. That being said, don't change this; it will go away with the merge of PR 5086.
What github issue is this PR for, if any?
Resolves #5180
What changed, and why?
My CasesHow will this affect users?
Volunteer: New dropdown in the sidebar
Videos
Dropdown:
casa.dropdown.show.mp4
Old arrow behavior
buttons.old.mp4
Fixed arrow behavior
buttons.fixed.mp4