-
-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5086 Nav bar enhancement #5271
5086 Nav bar enhancement #5271
Conversation
fix code smell
JS Linting
There are gonna be merge conflicts here between this and #5272. I can clean them up depending on the order they are merged. |
// ======== Sidebar colors | ||
$sidebar-inactive: #9AA4CA; | ||
$sidebar-active: #365CF5; | ||
$sidebar-dark: #1A2142; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the use of creating variables for these colors. Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schoork thanks so much for working on this! I'm getting really jumpy behavior on the hamburger menu on the small screen. Are you seeing differently?
Screen.Recording.2023-10-20.at.11.15.14.AM.mov
@littleforest I did when I used the Chrome tools to get a smaller screen and did not refresh after. Try refreshing the page and it should go away. I felt like that was ignorable edge case, but could do some more work if you think it's worth supporting. |
No, @littleforest, you're totally right. |
Response to CR
could not override md size, chnage of 2 pixels from verifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schoork this is such an improvement, thank you so much for working on this! The stakeholders will be so happy.
What github issue is this PR for, if any?
Resolves #5086
What changed, and why?
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Screenshots please :)
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)
Feedback please? (optional)
We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9