Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5086 Nav bar enhancement #5271

Merged
merged 6 commits into from
Oct 22, 2023
Merged

5086 Nav bar enhancement #5271

merged 6 commits into from
Oct 22, 2023

Conversation

schoork
Copy link
Collaborator

@schoork schoork commented Oct 9, 2023

What github issue is this PR for, if any?

Resolves #5086

What changed, and why?

  • Mobile:
    • button on bar makes collapsible/openable
  • Desktop:
    • when minimized shows narrow bar with icons
    • when minimized and hovered over expands to full width

How will this affect user permissions?

  • Volunteer permissions: None
  • Supervisor permissions: None
  • Admin permissions: None

How is this tested? (please write tests!) 💖💪

  • components
    • spec/components/sidebar/group_component_spec.rb
    • spec/components/sidebar/link_component_spec.rb
  • system
    • spec/system/case_contacts/index_spec.rb
    • spec/system/case_contacts/index_spec.rb
  • views
    • spec/views/layouts/sidebar.html.erb_spec.rb

Screenshots please :)

Screenshot 2023-10-09 at 7 34 30 PM
Screenshot 2023-10-09 at 7 34 25 PM
Screenshot 2023-10-09 at 7 32 00 PM
Screenshot 2023-10-09 at 7 31 55 PM
Screenshot 2023-10-09 at 7 31 50 PM

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

Feedback please? (optional)

We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9

@schoork schoork linked an issue Oct 9, 2023 that may be closed by this pull request
@github-actions github-actions bot added javascript for use by Github Labeler to mark pull requests that update Javascript code ruby Pull requests that update Ruby code Tests! 🎉💖👏 erb labels Oct 9, 2023
Sam Williams added 2 commits October 9, 2023 20:27
@schoork
Copy link
Collaborator Author

schoork commented Oct 13, 2023

There are gonna be merge conflicts here between this and #5272. I can clean them up depending on the order they are merged.

// ======== Sidebar colors
$sidebar-inactive: #9AA4CA;
$sidebar-active: #365CF5;
$sidebar-dark: #1A2142;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the use of creating variables for these colors. Good job!

Copy link
Collaborator

@littleforest littleforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schoork thanks so much for working on this! I'm getting really jumpy behavior on the hamburger menu on the small screen. Are you seeing differently?

Screen.Recording.2023-10-20.at.11.15.14.AM.mov

@schoork
Copy link
Collaborator Author

schoork commented Oct 20, 2023

@littleforest I did when I used the Chrome tools to get a smaller screen and did not refresh after. Try refreshing the page and it should go away. I felt like that was ignorable edge case, but could do some more work if you think it's worth supporting.

@schoork
Copy link
Collaborator Author

schoork commented Oct 22, 2023

No, @littleforest, you're totally right. window.screen.width literally gets the size of your screen, whereas winow.innerWidth gets the size of the browser window. Good catch!

Sam Williams added 3 commits October 22, 2023 08:20
could not override md size, chnage of 2 pixels from verifications
Copy link
Collaborator

@littleforest littleforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schoork this is such an improvement, thank you so much for working on this! The stakeholders will be so happy.

@littleforest littleforest merged commit 884504c into main Oct 22, 2023
14 checks passed
@littleforest littleforest deleted the 5086-nav-bar-enhancement branch October 22, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
erb javascript for use by Github Labeler to mark pull requests that update Javascript code ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nav Bar Enhancement
3 participants