actionpack: Do not redefine ActionController::Base.rescue_from #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
fix_mixin_structure_of_actioncontoroller
branch
2 times, most recently
from
e152c45 to
ab6b370
Compare
`.rescue_from` method is defined in `ActiveSupport::Rescuable::ClassMethods`. Therefore it would be better to extend it instead of redefinition.
tk0miya
force-pushed
the
fix_mixin_structure_of_actioncontoroller
branch
from
1fa770c to
501185c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.rescue_frommethod is defined inActiveSupport::Rescuable::ClassMethods. Therefore it would be better to extend it instead of redefinition.