Move rescue_from type from an interface to ActiveSupport::Rescuable::ClassMethods
#462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.rescue_from` method is defined in `ActiveSupport::Rescuable::ClassMethods`. Therefore it would be better to extend it instead of redefinition.
sw-square
pushed a commit
to sw-square/gem_rbs_collection
that referenced
this pull request
Jan 22, 2024
…::ClassMethods (ruby#462) * actionpack: Do not redefine ActionController::Base.rescue_from `.rescue_from` method is defined in `ActiveSupport::Rescuable::ClassMethods`. Therefore it would be better to extend it instead of redefinition. * Move rescue_from type definition from an interface to a class --------- Co-authored-by: Takeshi KOMIYA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #438
PR #438 ignores the well-typed
rescue_fromdefinition, so I replaced the type ofActiveSupport::Rescuable::ClassMethods#rescue_fromwith the definition defiend in the interface.