-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Python backgrounds threads to run in parallel with R #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the easiest way to write and export c++ functions that don't follow the standard gil usage pattern.
kevinushey
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows spawned Python background threads to run while the main thread is executing R code.
For example, if you start a Python background thread like this:
With the current reticulate release, we don't see any output from the Python thread while at the R repl. The Python thread only is active while we are in a Python function that gives an opportunity for the GIL to be released (e.g, an explicit sleep, or evaluating Python bytecode). E.g., we only see output from the above background thread if we call in R:
However, with this PR, we now see output from the Python background thread even when not calling into Python from the main thread.
The primary motivation is to allow a Positron Python console to be backed by the same Python session reticulate in the Positron R console is using, without needing to block the R console, or spin-up+shutdown the ipykernel event loop on each call to
repl_python()
.