Updates to enable repl_python() to use Positron Python kernel
#1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All R functions called by Python first check if they're on the main thread, and if not, are rescheduled on the main thread.
t-kalinowski
force-pushed
the
positron-repl_python
branch
from
2b46c7d to
99843ed
Compare
kevinushey
reviewed
Aug 21, 2024
|
|
||
| void safe_print_value(SEXP value, const char* warn_print_failed) { | ||
| // Use R_ToplevelExec to safely execute Rf_PrintValue with an inlined lambda | ||
| if (!R_ToplevelExec([](void* data) -> void { |
Will need a better approach
t-kalinowski
changed the title
repl_python() to use independent Console session in Positronrepl_python() to use independent Console session in Positron
t-kalinowski
changed the title
repl_python() to use independent Console session in Positronrepl_python() to use Positron Python kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works towards making
repl_python()able to use Positron Python features and makingrepl_python()a peer experience to using the Python language pack in Positron.The updates primarily involve under-the-hood changes to support this goal. These include:
py_main_thread_func()obsolete and deprecated.This work continues from #1641, which allowed background Python threads to run concurrently with R on the main thread.