Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jazzy] Bugfix for bag_split event callbacks called to early with file compression (backport #1643) #1732

Merged
merged 1 commit into from
Jul 12, 2024

Commits on Jun 26, 2024

  1. Bugfix for bag_split event callbacks called to early with file compre…

    …ssion (#1643)
    
    * Bugfix for bag_split event callbacks not called with file compression
    
    Signed-off-by: Michael Orlov <[email protected]>
    
    * Delete redundant "should_split_bagfile" in compression_writer
    
    - It is a non-virtual method and doesn't call from the base class.
    
    Signed-off-by: Michael Orlov <[email protected]>
    
    * Adjust "split_event_calls_callback" for testing multiple splits
    
    Signed-off-by: Michael Orlov <[email protected]>
    
    * Use temp folder for "SequentialWriterTest" fixture instead of "uri"
    
    Signed-off-by: Michael Orlov <[email protected]>
    
    * Add tests for split event callbacks when using file and msg compression
    
     - Added "split_event_calls_callback_with_msg_compression" and
    "split_event_calls_callback_with_file_compression" uit tests
    
    Signed-off-by: Michael Orlov <[email protected]>
    
    * Add debug info to the flaky "can_record_again_after_stop" test
    
    Signed-off-by: Michael Orlov <[email protected]>
    
    * Use `uint64_t` type for `fake_storage_size_` in tests
    
    Signed-off-by: Michael Orlov <[email protected]>
    
    ---------
    
    Signed-off-by: Michael Orlov <[email protected]>
    (cherry picked from commit 1877b53)
    MichaelOrlov authored and mergify[bot] committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7c8ed48 View commit details
    Browse the repository at this point in the history