Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating tf2 C Headers #98

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from

Conversation

CursedRock17
Copy link

@CursedRock17 CursedRock17 commented Oct 29, 2024

Related to this pull request in geometry2 in which we deprecated the .h style headers in favor of .hpp.

Edit: I should mention this is meant to be a preemptive PR for if/when the related pull request gets approved. I'm also working on a backport so there won't be distribution issues

@clalancette clalancette changed the base branch from kinetic-devel to rolling October 31, 2024 11:36
@clalancette
Copy link

@CursedRock17 I retargeted this at the rolling branch, and this now needs a rebase.

Signed-off-by: CursedRock17 <[email protected]>
Signed-off-by: CursedRock17 <[email protected]>
@CursedRock17
Copy link
Author

A bit wonkey but it seems to like the rebase.

@clalancette
Copy link

Pulls: ros2/geometry2#720, ros2/rviz#1289, #98
Gist: https://gist.githubusercontent.com/clalancette/b83127091186f2489c09c4c787585861/raw/3c16fd56b4d645d09b9cadf800da79cbfd1acbaf/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14792

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants