Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various bug fixes and cleanup #212

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Various bug fixes and cleanup #212

merged 8 commits into from
Oct 15, 2024

Conversation

klingaard
Copy link
Collaborator

  • DIspatch stall counts were off by one stall condition providing incorrect stall counts
  • The handshake between the LS and Data was off by one cycle forcing the LS to always see a cache miss even when hit
  • Some basic cleanup on the code

@klingaard klingaard added the bug Something isn't working label Oct 8, 2024
@klingaard klingaard self-assigned this Oct 8, 2024
@klingaard
Copy link
Collaborator Author

klingaard commented Oct 8, 2024 •
edited
Loading

The bug fix on dcache response. This is a JSON file back to back loads (same address) with always hit DTLB and Dcache.

Before:
image

After:
Screenshot from 2024-10-08 17-04-50

@klingaard klingaard merged commit 1f6f187 into master Oct 15, 2024
5 checks passed
@klingaard klingaard deleted the klingaard/various_bug_fixes branch October 15, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathlenemagnus kathlenemagnus kathlenemagnus approved these changes

@h0lyalg0rithm h0lyalg0rithm Awaiting requested review from h0lyalg0rithm

@arupc arupc Awaiting requested review from arupc

@MayneMei MayneMei Awaiting requested review from MayneMei

Assignees

@klingaard klingaard

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klingaard @kathlenemagnus @knute-mips