Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jeffnye gh/fsl submodule #175

Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,6 @@
[submodule "stf_lib"]
path = stf_lib
url = https://github.com/sparcians/stf_lib.git
[submodule "fsl"]
path = fsl
url = [email protected]:Condor-Performance-Modeling/fsl.git
8 changes: 6 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,19 @@ set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g")

# Include directories
include_directories (core mss sim)
include_directories (SYSTEM fusion)
include_directories (SYSTEM fsl)
include_directories (SYSTEM mavis)
include_directories (SYSTEM stf_lib)

# Mavis, the Core, MSS, the simulator and Fusion

add_subdirectory (mavis)
add_subdirectory (core)
add_subdirectory (mss)
add_subdirectory (fusion)

# Tell FSL to use the top mavis submodule, instead of fsl's submodule
set(FSL_MAVIS_PATH "${CMAKE_CURRENT_SOURCE_DIR}/mavis")
add_subdirectory (fsl)

# Add STF library to the build
add_subdirectory (${STF_LIB_BASE})
Expand Down
2 changes: 1 addition & 1 deletion core/Decode.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// <Decode.cpp> -*- C++ -*-

#include "Decode.hpp"
#include "fusion/FusionTypes.hpp"
#include "fsl_api/FusionTypes.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why the change in name?

Copy link
Collaborator Author

@jeffnye-gh jeffnye-gh Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the early days fusion was accurate, I have cases where I want to apply the language to fracture, some RV extensions and for vector.

I chose fsl_api and fsl_interp to separate the namespaces.

It could have been fsl and fsl_interp for the symmetry and to quiet my OCD.

Olympia is the lead use case, so if you prefer I can change fsl_api to fsl.


#include "sparta/events/StartupEvent.hpp"
#include "sparta/utils/LogUtils.hpp"
Expand Down
12 changes: 6 additions & 6 deletions core/Decode.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
#include "FlushManager.hpp"
#include "InstGroup.hpp"

#include "fusion/FieldExtractor.hpp"
#include "fusion/Fusion.hpp"
#include "fusion/FusionGroup.hpp"
#include "fusion/FusionTypes.hpp"
#include "fusion/HCache.hpp"
#include "fusion/MachineInfo.hpp"
#include "fsl_api/FieldExtractor.h"
#include "fsl_api/Fusion.h"
#include "fsl_api/FusionGroup.h"
#include "fsl_api/FusionTypes.h"
#include "fsl_api/HCache.h"
#include "fsl_api/MachineInfo.h"

#include "sparta/ports/DataPort.hpp"
#include "sparta/events/UniqueEvent.hpp"
Expand Down
3 changes: 2 additions & 1 deletion core/FusionDecode.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// TODO: add Condor header - this is a new file
// contact jeff at condor
#include "fusion/FusionTypes.hpp"
//#include "fusion/FusionTypes.hpp"
#include "fsl_api/FusionTypes.h"
#include "Decode.hpp"

#include "sparta/events/StartupEvent.hpp"
Expand Down
1 change: 1 addition & 0 deletions fsl
Submodule fsl added at a7fb34
45 changes: 0 additions & 45 deletions fusion/CMakeLists.txt

This file was deleted.

Loading
Loading