Jeffnye gh/fsl submodule #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 14, 2024 14:01
top level cmakefile creates a variable that tells fsl to use oly's mavis, not fsl's mavis submodule having both helps fsl development
klingaard
approved these changes
Jun 17, 2024
| @@ -1,7 +1,7 @@ | |||
| // <Decode.cpp> -*- C++ -*- | |||
|
|
|||
| #include "Decode.hpp" | |||
| #include "fusion/FusionTypes.hpp" | |||
| #include "fsl_api/FusionTypes.h" | |||
There was a problem hiding this comment.
Curious, why the change in name?
There was a problem hiding this comment.
In the early days fusion was accurate, I have cases where I want to apply the language to fracture, some RV extensions and for vector.
I chose fsl_api and fsl_interp to separate the namespaces.
It could have been fsl and fsl_interp for the symmetry and to quiet my OCD.
Olympia is the lead use case, so if you prefer I can change fsl_api to fsl.
added 2 commits
July 25, 2024 11:33
…nce-Modeling/riscv-perf-model-f4 into jeffnye-gh/fsl_submodule
|
I pushed an update to correct the conflicts. re-requesting review The push did not trigger the git runner, i do not know if it is supposed to for this change. |
Signed-off-by: jeffnye-gh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert fusion support to sub-module fsl.
remove the old fusion dir. Add a cmake var so fsl uses olympia/mavis when it is instantiated as a submodule.