Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of logic app standard deployment bug #316

Merged
merged 8 commits into from
Apr 26, 2023

Conversation

tjezek
Copy link
Contributor

@tjezek tjezek commented Apr 26, 2023

This is PR to fix logic app standard changes deployment described here #315. This solution uses local-exec linux shell to crete deploy.zip file with untouched timestamps. The problem is that it's dependent on 'ubuntu-latest' machine which has 'zip' package preinstalled. I don't know how we should solve this OS specific, so I want to discuss this here.

@tjezek tjezek requested review from a team and tom-reinders as code owners April 26, 2023 06:12
@tjezek tjezek linked an issue Apr 26, 2023 that may be closed by this pull request
@bartwesselink
Copy link

@tjezek nice catch. Is it possible that we just add a check and say that it is currently only supportedf on Ubuntu?

Co-authored-by: tom-reinders <[email protected]>
@tom-reinders tom-reinders self-requested a review April 26, 2023 14:53
@tom-reinders tom-reinders added this to the v3.3.0 milestone Apr 26, 2023
@tom-reinders tom-reinders merged commit cdae9fc into develop Apr 26, 2023
@tom-reinders tom-reinders deleted the bug/logic-app-standard-deployment branch April 26, 2023 15:01
@tom-reinders tom-reinders mentioned this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes not reflected after Logic App Standard deployment
4 participants