Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes not reflected after Logic App Standard deployment #315

Closed
tjezek opened this issue Apr 26, 2023 · 0 comments · Fixed by #316
Closed

Changes not reflected after Logic App Standard deployment #315

tjezek opened this issue Apr 26, 2023 · 0 comments · Fixed by #316
Labels
bug Something isn't working
Milestone

Comments

@tjezek
Copy link
Contributor

tjezek commented Apr 26, 2023

Describe the bug
Changes made inside existing logic app file (workflow.json, parameters.json, connections.json) deployed via Logic App Standard module (https://github.com/recognizegroup/terraform/tree/develop/modules/azure/logic_app_standard) are not reflected. This causes problem if you want to update/fix logic app from code and deploy the change to an environment.

To reproduce

  1. in exisiting logic app change parameter.json or workflow.json (add parameter, change action name etc.)
  2. deploy this change via Logic App Standard module
  3. go to logic app in Azure Portal and check deployment logs
  4. OK: deployment has been done
  5. go to changed file (paramtere.json or workflow.json) to check the change
  6. BUG: nothing has changed

Expected behavior
Changes should be reflected after logic app deployment.

Environment
any - local PC (Windows 10), Ubuntu (Latest) pipeline

Notes
This problem is caused by terraform archive_file module which is changing change timestamp of archived files (hashicorp/terraform-provider-archive#40). Zip file created by the module is deployed via Kudu ZIP deploy (https://learn.microsoft.com/en-us/azure/app-service/deploy-zip?tabs=cli). Kudu is comparing changed timestamps and updates only changed one (see Efficient file copy in https://github.com/projectkudu/kudu/wiki/Deploying-from-a-zip-file-or-url). The issue in archive_file module leads to timestamp is always the same (Jan 1 2049). No changed files are copied by Kudu then. Only new files are copied for the first time.

@tjezek tjezek added the bug Something isn't working label Apr 26, 2023
@tjezek tjezek linked a pull request Apr 26, 2023 that will close this issue
@tom-reinders tom-reinders added this to the v3.3.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants