Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed merge to union #19

Merged
merged 2 commits into from
Jan 4, 2019
+6 −6
Merged

renamed merge to union #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f9e4fa
renamed merge to union
bergos Jan 2, 2019
a2e3831
Update dataset-spec.html
blake-regalia Jan 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions dataset-spec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,11 @@ <h3><dfn>Dataset</dfn> interface</h3>
Promise&lt;Dataset&gt; import (Stream stream);
Dataset intersection (Dataset other);
Dataset map (QuadMapIteratee iteratee);
Dataset merge ((Dataset or sequence&lt;Quad&gt;) quads);
boolean some (QuadFilterIteratee iteratee);
String toCanonical ();
Stream toStream ();
String toString ();
Dataset union (Dataset quads);
};
</pre>

Expand Down Expand Up @@ -246,11 +246,6 @@ <h3>Methods</h3>
</p>
<p>Returns a new dataset containing all quads returned by applying <code>iteratee</code> to each quad in the current dataset.</p>

<p>
<dfn>merge</dfn>
</p>
<p>Returns a new <a>Dataset</a> that is a concatenation of this dataset and the <code>quads</code> given as an argument.</p>

<p>
<dfn>some</dfn>
</p>
Expand All @@ -273,6 +268,11 @@ <h3>Methods</h3>
</p>
<p>Returns an N-Quads string representation of the dataset.</p>
<p>No normalization is done before, so the results for the same quads may vary based on the Dataset implementation.</p>

<p>
<dfn>union</dfn>
</p>
<p>Returns a new <a>Dataset</a> that is a concatenation of this dataset and the <code>quads</code> given as an argument.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"concatenation" may be an oversimplification. If any of the datasets contain equal blank nodes, then the blank nodes should be standardized apart according to the RDF spec.

It may be good to link to the section on graph merging in the RDF spec.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't changed the wording. So it only shows up as a change, cause it's sorted alphabetically. Let's keep this PR just about the renaming of merge to union.

Your comments are worth another issue. In the past I've implemented it just as a concatenation and haven't thought about the impact.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, opened #22 for this.

</section>

<section data-dfn-for="DatasetFactory">
Expand Down