renamed merge to union #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubensworks
requested changes
Jan 2, 2019
| <p> | ||
| <dfn>union</dfn> | ||
| </p> | ||
| <p>Returns a new <a>Dataset</a> that is a concatenation of this dataset and the <code>quads</code> given as an argument.</p> |
There was a problem hiding this comment.
"concatenation" may be an oversimplification. If any of the datasets contain equal blank nodes, then the blank nodes should be standardized apart according to the RDF spec.
It may be good to link to the section on graph merging in the RDF spec.
There was a problem hiding this comment.
I haven't changed the wording. So it only shows up as a change, cause it's sorted alphabetically. Let's keep this PR just about the renaming of merge to union.
Your comments are worth another issue. In the past I've implemented it just as a concatenation and haven't thought about the impact.
There was a problem hiding this comment.
Good point, opened #22 for this.
vhf
approved these changes
Jan 3, 2019
rubensworks
approved these changes
Jan 3, 2019
blake-regalia
suggested changes
Jan 3, 2019
Co-Authored-By: bergos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16