-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature RDF/JS #118
Feature RDF/JS #118
Conversation
I can still change it if you prefer a complete breaking change, in which case more invasive internal changes to the writer will need to be done. |
Thanks @rubensworks, breaking changes are fine with me. v1.0.0 will not be backward compatible. |
@RubenVerborgh I removed backwards compatibility with the string-based interface of N3Writer. However, internally everything currently still works with the old string-based representation. I believe this will have better performance than using the RDF/JS datastructures for everything internally as well. |
@RubenVerborgh Everything should be compatible with the RDF/JS interface now. I had to make some design decisions, such as converting everything to a string-based representation internally, and the way For reference, I've updated the TS typings, so you can see there what the (intended) types and signatures are. |
Have you tried running the test suite mentioned in rdfjs/data-model-spec#47 (comment) ? |
@elf-pavlik Thanks for the suggestion, I'll look into it soon. |
It looks like the test suite is built around |
@rubensworks the test suite moved to rdf-data-model. Old documentation is still valid. |
@RubenVerborgh N3Util now implements the DataFactory interface, as requested in #122. The test suite from @bergos also succeeds, except for one test regarding default graphs, which I believe is a mistake in the tests (rdfjs-base/data-model#3) |
Is performance worse or similar with the new interface? @rubensworks |
Slightly worse last time I tested, but acceptable. |
Would this PR make N3.js ready for a new major release? |
Yes, this will become v1.0.0 when finished. I just desperately need 1 full
day to work on this.
|
78e50ae
to
f9b355e
Compare
95e297e
to
0d5bc24
Compare
Doesn't make sense with RDF/JS.
Adds compatibility with the RDF/JS Sink interface.
Adds compatibility with the RDF/JS Sink interface.
aeceb7b
to
a435548
Compare
It's up to webpack or browserify to do that.
217fca6
to
b8f621b
Compare
9e7112a
to
c6435ff
Compare
Thanks for your help, @rubensworks. I've heavily modified the interfaces, so the TypeScript definitions will be obsolete. I've removed usage of the internal representation from most places, and many helper methods from Util are gone. |
Great! I will look into updating the TS typings soon. |
To do: