-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cuvs_bench.run python code and build #279
Merged
Merged
Changes from 26 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
7e37218
FEA Add cuvs-bench to dependencies and conda environments
dantegd b2aef6d
FIX add missing deps
dantegd bf75242
FIX version and other improvements
dantegd a8bcdef
FEA Add cuvs_bench.run
dantegd ec6d70c
FIX some cuvs_bench python build dependencies
dantegd 585ad53
FIX add missing algorithms.yaml
dantegd bb9dc28
Merge branch 'branch-24.10' into cuvsbench-run
cjnolet a400e4c
ENH refactor run code and add prompts to CLI
dantegd 0e36e21
FEA Add first version of pytests
dantegd f652172
Merge branch 'cuvsbench-run' of github.com:dantegd/cuvs into cuvsbenc…
dantegd a8652e0
Merge branch 'branch-24.10' into cuvsbench-run
cjnolet 17264f1
Merge branch 'branch-24.10' into cuvsbench-run
cjnolet 5e36a13
Merge dev branch and branch-24.10
dantegd f4cbdf5
FIX more merge conflicts
dantegd 20886a0
Merge branch 'branch-24.10' into cuvsbench-run
dantegd 742e7c5
fix runners
divyegala c342662
Merge branch 'branch-24.10' into cuvsbench-run
divyegala 1ef9a6e
Merge branch 'branch-24.10' into cuvsbench-run
rhdong 9b69460
pre-commit
divyegala bce9d22
Merge remote-tracking branch 'upstream/branch-24.10' into cuvsbench-run
divyegala 6deb9ca
Merge branch 'branch-24.10' into cuvsbench-run
divyegala 2b4cf8c
remove bench-ann build from cpp conda recipe
divyegala 611f190
address review
divyegala 2f868bb
Manage rapids-build-backend dependencies with dependencies.yaml.
bdice f460b3b
Remove extraneous file listing.
bdice 8a82802
Fixes discussed with Divye.
bdice ac81e2f
Apply suggestions from code review
divyegala b2e5c48
json ignore only in root
divyegala 0606697
Merge branch 'branch-24.10' into cuvsbench-run
cjnolet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,3 +79,6 @@ cagra_index | |
ivf_flat_index | ||
ivf_pq_index | ||
|
||
# cuvs_bench | ||
datasets/ | ||
*.json | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
#!/usr/bin/env bash | ||
# Copyright (c) 2022-2024, NVIDIA CORPORATION. | ||
|
||
./build.sh tests bench-ann --allgpuarch --no-nvtx --build-metrics=tests_bench --incl-cache-stats | ||
./build.sh tests --allgpuarch --no-nvtx --build-metrics=tests_bench --incl-cache-stats | ||
divyegala marked this conversation as resolved.
Show resolved
Hide resolved
|
||
cmake --install cpp/build --component testing |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# | ||
# Copyright (c) 2024, NVIDIA CORPORATION. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
from .algos.constraints import * |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
faiss_gpu_flat: | ||
executable: FAISS_GPU_FLAT_ANN_BENCH | ||
requires_gpu: true | ||
faiss_gpu_ivf_flat: | ||
executable: FAISS_GPU_IVF_FLAT_ANN_BENCH | ||
requires_gpu: true | ||
faiss_gpu_ivf_pq: | ||
executable: FAISS_GPU_IVF_PQ_ANN_BENCH | ||
requires_gpu: true | ||
faiss_gpu_ivf_sq: | ||
executable: FAISS_GPU_IVF_PQ_ANN_BENCH | ||
requires_gpu: true | ||
faiss_cpu_flat: | ||
executable: FAISS_CPU_FLAT_ANN_BENCH | ||
requires_gpu: false | ||
faiss_cpu_ivf_flat: | ||
executable: FAISS_CPU_IVF_FLAT_ANN_BENCH | ||
requires_gpu: false | ||
faiss_cpu_ivf_pq: | ||
executable: FAISS_CPU_IVF_PQ_ANN_BENCH | ||
requires_gpu: false | ||
cuvs_ivf_flat: | ||
executable: CUVS_IVF_FLAT_ANN_BENCH | ||
requires_gpu: true | ||
cuvs_ivf_pq: | ||
executable: CUVS_IVF_PQ_ANN_BENCH | ||
requires_gpu: true | ||
cuvs_cagra: | ||
executable: CUVS_CAGRA_ANN_BENCH | ||
requires_gpu: true | ||
cuvs_brute_force: | ||
executable: CUVS_BRUTE_FORCE_ANN_BENCH | ||
requires_gpu: true | ||
ggnn: | ||
executable: GGNN_ANN_BENCH | ||
requires_gpu: true | ||
hnswlib: | ||
executable: HNSWLIB_ANN_BENCH | ||
requires_gpu: false | ||
cuvs_cagra_hnswlib: | ||
executable: CUVS_CAGRA_HNSWLIB_ANN_BENCH | ||
requires_gpu: true |
Empty file.
2 changes: 1 addition & 1 deletion
2
...vs_bench/cuvs_bench/config/constraints.py → ...ench/config/algos/constraints/__init__.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be more specific? We use
.json
files for configuration and this would cause them to never have changes committed.Examples:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I'll remove this. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant I'll make it more specific to only ignore
.json
files from root directory