Add cuvs_bench.run python code and build #279
Conversation
cjnolet
added
improvement
|
@rapidsai/packaging-codeowners could we get a review here please? |
.gitignore
Outdated
| @@ -79,3 +79,6 @@ cagra_index | |||
| ivf_flat_index | |||
| ivf_pq_index | |||
|
|
|||
| # cuvs_bench | |||
| datasets/ | |||
| *.json | |||
There was a problem hiding this comment.
Can this be more specific? We use .json files for configuration and this would cause them to never have changes committed.
Examples:
There was a problem hiding this comment.
Good point, I'll remove this. Thanks!
There was a problem hiding this comment.
Sorry, I meant I'll make it more specific to only ignore .json files from root directory
Co-authored-by: Bradley Dice <[email protected]>
| @@ -79,3 +79,6 @@ cagra_index | |||
| ivf_flat_index | |||
| ivf_pq_index | |||
|
|
|||
| # cuvs_bench | |||
| datasets/ | |||
| /*.json | |||
There was a problem hiding this comment.
Can we add back the trailing newline? And is there a name pattern that we can attach to this? Like “/bench*.json”? It’s very possible that we might want top level configuration in JSON.
There was a problem hiding this comment.
We'll rework this if we add top-level JSON configurations later on. For now, this tool sometimes create top-level JSON files so we'll refactor it, if needed, so it doesn't do that
|
/merge |
Builds on top of #279, will change from draft after that merge, or we can merge into one single PR if reviewers prefer so. Authors: - Dante Gama Dessavre (https://github.com/dantegd) - Corey J. Nolet (https://github.com/cjnolet) - Divye Gala (https://github.com/divyegala) - rhdong (https://github.com/rhdong) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #347
Builds on top of #275