Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove another reference to FindcuFile #17315

Merged
merged 9 commits into from
Nov 15, 2024
Merged

Remove another reference to FindcuFile #17315

merged 9 commits into from
Nov 15, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Nov 13, 2024 •
edited
Loading

Description

The reference in JNI was missed in #17298. Replace it with FindCUDAToolkit.

Also backport FindCUDAToolkit from CMake 3.31 to get https://gitlab.kitware.com/cmake/cmake/-/commit/b38a8e77cb3c8401b3022a68f07a4fd77b290524.

Also add an option to statically link cuFile.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@KyleFromNVIDIA
Remove another reference to FindcuFile
beb3817 
The reference in JNI was missed in rapidsai#17298. Replace it with
FindCUDAToolkit.
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner November 13, 2024 22:09
@github-actions github-actions bot added CMake CMake build issue Java Affects Java cuDF API. labels Nov 13, 2024
@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Non-breaking change labels Nov 13, 2024
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners November 14, 2024 16:27
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 14, 2024
@jlowe jlowe mentioned this pull request Nov 14, 2024
Merged
vyasr
vyasr approved these changes Nov 14, 2024
View reviewed changes
cpp/CMakeLists.txt Show resolved Hide resolved
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 81cd4a0 into rapidsai:branch-24.12 Nov 15, 2024
102 checks passed
@gerashegalov gerashegalov mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@gerashegalov gerashegalov gerashegalov approved these changes

@vyasr vyasr vyasr approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/ci-codeowners

@bdice bdice Awaiting requested review from bdice

Assignees

@KyleFromNVIDIA KyleFromNVIDIA

Labels
bug Something isn't working CMake CMake build issue Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KyleFromNVIDIA @vyasr @gerashegalov @bdice @ttnghia