Update method for locating cufile and remove unused libcudf cmake options #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Signed-off-by: Jason Lowe <[email protected]>
3 tasks
KyleFromNVIDIA
approved these changes
Nov 14, 2024
hyperbolic2346
previously approved these changes
Nov 14, 2024
revans2
reviewed
Nov 14, 2024
|
build |
gerashegalov
previously approved these changes
Nov 14, 2024
There was a problem hiding this comment.
In this repo we could just upgrade CMake
|
CI FAILED #764 |
jlowe
dismissed stale reviews from gerashegalov, pxLi, and hyperbolic2346
via
5e25cbc
|
Waiting for new CI images to be published with the changes from #2597 before kicking off another CI run. |
gerashegalov
approved these changes
Nov 15, 2024
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to rapidsai/cudf#17298 and rapidsai/cudf#17315. FindcuFile.cmake was removed, so this updates the spark-rapids-jni CMakeLists.txt to use a similar approach as to the RAPIDS PRs. Like those PRs, this adds a backported FindCUDAToolkit.cmake to work around a bug in older cmake versions where libcufile could not be found.
This also adds the upcoming CUDA_STATIC_CUFILE flag so we do not dynamically link libcufile, and some unused libcudf cmake options were removed.