Allow removing filesystem info for local files #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
gerritholl
approved these changes
Jan 10, 2025
| @@ -4,6 +4,14 @@ | |||
|
|
|||
| An example configuration file to retrieve data from a directory. | |||
|
|
|||
| For backwards compatibility with pytroll collector’s trollstalker, the message config can have the `no_fs` set to | |||
| `true` to sent messages without filesystem information and without `file://` prepended to the file uri. | |||
There was a problem hiding this comment.
Suggested change
| `true` to sent messages without filesystem information and without `file://` prepended to the file uri. | |
| `true` to send messages without filesystem information and without `file://` prepended to the file uri. |
| with suppress(AttributeError): # fileitem is not a UPath if it cannot access .fs | ||
| with dummy_connect(file_item): | ||
| file_location["filesystem"] = json.loads(file_item.fs.to_json(include_password=False)) | ||
| if no_fs: | ||
| raise ValueError("Can’t have no_fs with remote files…") |
There was a problem hiding this comment.
Suggested change
| raise ValueError("Can’t have no_fs with remote files…") | |
| raise ValueError("Can't have no_fs with remote files…") |
I think we usually prefer ASCII source code (’ is RIGHT SINGLE QUOTATION MARK, 0x2019).
| message_config=message_settings) | ||
| assert len(published_messages) == 1 | ||
| message = Message(rawstr=published_messages[0]) | ||
| assert message.data["uri"].startswith("/") # or `os.sep` ? |
There was a problem hiding this comment.
Could this be different from "/"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #41