Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only drop scheme for file type messages #161

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gerritholl
Copy link
Member

Limit removing the scheme from the URI to incoming messages of type 'file'.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12711822012

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.775%

Totals Coverage Status
Change from base Build 11931253671: 0.0%
Covered Lines: 4113
Relevant Lines: 4531

💛 - Coveralls

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (afb6cae) to head (4f2a044).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files          28       28           
  Lines        4005     4005           
=======================================
  Hits         3676     3676           
  Misses        329      329           
Flag Coverage Δ
unittests 91.78% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gerritholl
Copy link
Member Author

...although with the simultaneously published pytroll/pytroll-watchers#44 we don't really need it anymore...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

segment_gatherer skips dataset messages when all_files_are_local is set
2 participants