Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-128330: Terminal control characters should be restored on repl exit #128331

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+4 −1
Open

gh-128330: Terminal control characters should be restored on repl exit #128331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b5f84c
gh-128330: Terminal settings are not correctly restored on repl exit
citrus-it Dec 29, 2024
92f39f0
Add NEWS item
citrus-it Dec 29, 2024
35f88f9
Add comment
citrus-it Jan 12, 2025
8e6e0ea
restore news item
citrus-it Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/_pyrepl/fancy_termios.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ def as_list(self):
self.lflag,
self.ispeed,
self.ospeed,
self.cc,
# Always return a copy of the control characters list to ensure
# there are not any additional references to self.cc
self.cc[:],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Let's add a comment explaining why this is here for future readers.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added one. Please let me know if you have suggestions for better wording.

]

def copy(self):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2024-12-29-15-09-21.gh-issue-128330.IaYL7G.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Restore terminal control characters on REPL exit.
Loading