gh-128330: Terminal control characters should be restored on repl exit #128331
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citrus-it
commented
Dec 29, 2024
•
citrus-it
commented
- Issue: Terminal settings are not correctly restored on repl exit #128330
citrus-it
requested review from
pablogsal,
lysnikolaou and
ambv
as code owners
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
| @@ -0,0 +1 @@ | |||
| Terminal control characters should be restored on repl exit | |||
There was a problem hiding this comment.
Suggested change
| Terminal control characters should be restored on repl exit | |
| Restore terminal control characters on REPL exit. |
There was a problem hiding this comment.
Did you revert this back on accident?
There was a problem hiding this comment.
Looks like it, sorry about that!
ZeroIntensity
added
needs backport to 3.13
| @@ -40,7 +40,7 @@ def as_list(self): | |||
| self.lflag, | |||
| self.ispeed, | |||
| self.ospeed, | |||
| self.cc, | |||
| self.cc[:], | |||
There was a problem hiding this comment.
Sorry for the delay. Let's add a comment explaining why this is here for future readers.
There was a problem hiding this comment.
I've added one. Please let me know if you have suggestions for better wording.
citrus-it
force-pushed
the
fancy_termios
branch
from
e720962 to
35f88f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.