Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue configuring in the normal way #1610

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Jan 2, 2024

@blampe points out in pulumi/pulumi-go-provider#172 it's might not be necessary to marshal with configencoding once we get past CheckConfig. Interesting idea. This works fine for a simple program on custom AWS build:

name: aws-yaml-configs
runtime: yaml
description: A minimal AWS Pulumi YAML program
outputs:
  # Export the name of the bucket
  bucketName: ${my-bucket.id}
resources:
  provider:
    type: pulumi:providers:aws
    properties:
      defaultTags:
        tags:
          foo: bar
    options:
      version: 6.17.0
  my-bucket:
    type: aws:s3:Bucket
    options:
      provider: ${provider}

Let me think of further testing. This can improve granularity of secret tracking.

@@ -667,7 +674,7 @@ func TestPreConfigureCallback(t *testing.T) {
"response": {
"inputs": {
"version": "6.54.0",
"configValue": "04da6b54-80e4-46f7-96ec-b56ff0331ba9"
"configValue": "dd056dcd-154b-4c76-9bd3-c8f88648b5ff"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now UnknownObjectValue = "dd056dcd-154b-4c76-9bd3-c8f88648b5ff" ... ever so slightly weird.

}
"batching": {
"enableBatching": true,
"sendAfter": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - improved granularity of secret marking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants