buildx auth #948
Closed
buildx auth #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 18, 2024
Closed
Closed
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
|
/run-acceptance-tests |
|
Please view the PR build: https://github.com/pulumi/pulumi-docker/actions/runs/7563399034 |
blampe
added a commit
to pulumi/ci-mgmt
that referenced
this pull request
Jan 18, 2024
I found it surprising when trying to [stack](https://stacking.dev) some PRs that we don't run tests unless the PR is explicitly against master. This is [awkward](pulumi/pulumi-docker#948 (comment)) to work with. This PR changes our workflow to trigger for PRs against any branch. I might be missing some context around #723 and why we chose to opt-in only some patterns, but if there are automated flows that shouldn't run tests I recommend we opt those out explicitly.
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
blampe
force-pushed
the
885-buildkit-mvp
branch
from
7b9e510 to
e3f225b
Compare
blampe
force-pushed
the
885-buildkit-mvp
branch
from
e3f225b to
d6af223
Compare
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
Maintainer note: consult the runbook for dealing with any breaking changes. |
blampe
force-pushed
the
887-auth
branch
2 times, most recently
from
aec9d28 to
4f568bf
Compare
blampe
force-pushed
the
885-buildkit-mvp
branch
from
d6af223 to
459d7b9
Compare
blampe
force-pushed
the
885-buildkit-mvp
branch
from
459d7b9 to
aa94f58
Compare
blampe
force-pushed
the
887-auth
branch
2 times, most recently
from
66d20fa to
36630df
Compare
blampe
force-pushed
the
885-buildkit-mvp
branch
from
233d3cd to
0a0b21c
Compare
blampe
force-pushed
the
885-buildkit-mvp
branch
from
0a0b21c to
cab7a28
Compare
This was referenced Feb 5, 2024
blampe
force-pushed
the
885-buildkit-mvp
branch
from
2e9e346 to
e4df22b
Compare
blampe
force-pushed
the
885-buildkit-mvp
branch
from
e4df22b to
a55249a
Compare
blampe
force-pushed
the
885-buildkit-mvp
branch
from
a55249a to
cde0908
Compare
blampe
force-pushed
the
885-buildkit-mvp
branch
from
cde0908 to
1d07075
Compare
Closed
blampe
force-pushed
the
885-buildkit-mvp
branch
2 times, most recently
from
f9110d9 to
6eb023c
Compare
blampe
force-pushed
the
887-auth
branch
2 times, most recently
from
4b60a8d to
283abcc
Compare
blampe
force-pushed
the
885-buildkit-mvp
branch
from
6eb023c to
a809074
Compare
blampe
force-pushed
the
885-buildkit-mvp
branch
2 times, most recently
from
de88fb3 to
ca7fbd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables authentication at the provider level for buildx.Images. A followup
will expose similar options for the Image resource.
Test coverage remains around ~89%.
Depends on pulumi/pulumi#15032
Depends on pulumi/pulumi-terraform-bridge#1610