[release tool] Slack notifications #9668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radTuti
added
docs-not-required
3 tasks
radTuti
force-pushed
the
slack-notifications
branch
from
5d877f3 to
4f12d18
Compare
radTuti
force-pushed
the
slack-notifications
branch
from
4f12d18 to
764e344
Compare
radTuti
force-pushed
the
slack-notifications
branch
from
fef6481 to
48b7f6b
Compare
release/Makefile
Outdated
| export ORGANIZATION | ||
| export GIT_REPO | ||
| export GIT_REPO_SLUG | ||
| export DEV_REGISTRIES | ||
| export OPERATOR_BRANCH | ||
|
|
||
| LDFLAGS= -X $(PACKAGE_NAME)/pkg/buildinfo.ProductName='$(PRODUCT_NAME)' |
There was a problem hiding this comment.
Why do we need to pass this in via LDFLAGs? What is the benefit of this over defining it as a constant in Golang?
radTuti
force-pushed
the
slack-notifications
branch
from
f5029d4 to
3f10f1e
Compare
radTuti
force-pushed
the
slack-notifications
branch
from
3f10f1e to
578a191
Compare
caseydavenport
approved these changes
Jan 13, 2025
radTuti
added a commit
to radTuti/calico
that referenced
this pull request
Jan 13, 2025
* slack notifications * allow setting debug via env var * cleanups * address review feedback * Compile product name into binary * use constant instead of ldflag
radTuti
added a commit
that referenced
this pull request
Jan 14, 2025
[release tool] Slack notifications (#9668)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This modifies how slack notifications are handled with the release tool to surface errors more.
Related issues/PRs
replaces #9350
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.