use constant instead of ldflag

release/Makefile

@@ -4,18 +4,12 @@ PACKAGE_NAME = github.com/projectcalico/calico/release
 
 include ../lib.Makefile
 
-# The name of the product.
-# Either "Calico" or "Calico Enterprise"
-PRODUCT_NAME=Calico
-
 export ORGANIZATION
 export GIT_REPO
 export GIT_REPO_SLUG
 export DEV_REGISTRIES
 export OPERATOR_BRANCH
 
-LDFLAGS= -X $(PACKAGE_NAME)/pkg/buildinfo.ProductName='$(PRODUCT_NAME)'
-
 .PHONY: build
 build: bin/release
 

release/cmd/main.go

@@ -24,7 +24,6 @@ import (
 
 	"github.com/projectcalico/calico/release/internal/command"
 	"github.com/projectcalico/calico/release/internal/utils"
-	"github.com/projectcalico/calico/release/pkg/buildinfo"
 	"github.com/projectcalico/calico/release/pkg/tasks"
 )
 
@@ -70,7 +69,7 @@ func main() {
 
 	app := &cli.App{
 		Name:                 "release",
-		Usage:                fmt.Sprintf("release tool for %s", buildinfo.ProductName),
+		Usage:                fmt.Sprintf("release tool for %s", utils.ProductName),
 		Flags:                globalFlags,
 		Commands:             Commands(cfg),
 		EnableBashCompletion: true,

release/internal/outputs/releasenotes.go

@@ -31,7 +31,6 @@ import (
 
 	"github.com/projectcalico/calico/release/internal/utils"
 	"github.com/projectcalico/calico/release/internal/version"
-	"github.com/projectcalico/calico/release/pkg/buildinfo"
 )
 
 const (
@@ -198,7 +197,7 @@ func ReleaseNotes(owner, githubToken, repoRootDir, outputDir string, ver version
 		outputDir = "."
 	}
 	logrus.Infof("Generating release notes for %s", ver.FormattedString())
-	milestone := ver.Milestone(buildinfo.ProductName)
+	milestone := ver.Milestone(utils.ProductName)
 	githubClient := github.NewTokenClient(context.Background(), githubToken)
 	releaseNoteDataList := []*ReleaseNoteIssueData{}
 	opts := &github.MilestoneListOptions{

release/internal/utils/utils.go

@@ -14,11 +14,10 @@
 
 package utils
 
-import "github.com/projectcalico/calico/release/pkg/buildinfo"
-
-var ProductName = buildinfo.ProductName
-
 const (
+	// ProductName is used in the release process to identify the product.
+	ProductName = CalicoProductName
+
 	// Calico is the product name for projectcalico.
 	Calico = "calico"
 
@@ -31,6 +30,9 @@ const (
 	// CalicoProductCode is the code for projectcalico.
 	CalicoProductCode = "os"
 
+	// CalicoProductName is the name of the projectcalico product.
+	CalicoProductName = "Calico"
+
 	// ProjectCalicoOrg is the name of the Project Calico organization.
 	ProjectCalicoOrg = "projectcalico"
 

release/internal/version/version.go

@@ -25,7 +25,6 @@ import (
 
 	"github.com/projectcalico/calico/release/internal/command"
 	"github.com/projectcalico/calico/release/internal/utils"
-	"github.com/projectcalico/calico/release/pkg/buildinfo"
 )
 
 // Data is the interface that provides version data for a release.
@@ -98,7 +97,7 @@ func (v *Version) FormattedString() string {
 // Milestone returns the GitHub milestone name which corresponds with this version.
 func (v *Version) Milestone(prefix string) string {
 	if prefix == "" {
-		prefix = buildinfo.ProductName
+		prefix = utils.ProductName
 	}
 	ver := semver.MustParse(string(*v))
 	return fmt.Sprintf("%s v%d.%d.%d", prefix, ver.Major(), ver.Minor(), ver.Patch())

release/pkg/tasks/notification.go

@@ -23,11 +23,10 @@ import (
 	"github.com/projectcalico/calico/release/internal/slack"
 	"github.com/projectcalico/calico/release/internal/utils"
 	"github.com/projectcalico/calico/release/internal/version"
-	"github.com/projectcalico/calico/release/pkg/buildinfo"
 	errr "github.com/projectcalico/calico/release/pkg/errors"
 )
 
-var product = buildinfo.ProductName
+var product = utils.ProductName
 
 // SendErrorNotification sends a slack notification for a given error.
 // The error type determines the message to send.