Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Beatmap Discussion article #3126

Merged
merged 9 commits into from
Apr 5, 2020
Merged

Conversation

Pennek
Copy link
Contributor

@Pennek Pennek commented Jan 30, 2020

aka. Modding v2

closes part of #3163 and #2615

tasks:

  • Add new Images
  • Insert links where appropriate
  • Check role tags
  • Re-arrange sections

@cl8n cl8n added the rewrite label Jan 30, 2020
@NoffyNoffeh NoffyNoffeh mentioned this pull request Jan 30, 2020
21 tasks
@Pennek Pennek requested a review from cl8n January 31, 2020 13:28
@Pennek
Copy link
Contributor Author

Pennek commented Jan 31, 2020

okay, i think thats it for now on beatmap discussions. still not satisfied with the naming of some of these sections, but i think more opinions would be good

@MegaApplePi MegaApplePi changed the title Rewrite Beatmap Discussions Rewrite Beatmap Discussion Feb 17, 2020
wiki/Beatmap_Discussion/en.md Outdated Show resolved Hide resolved
wiki/Beatmap_Discussion/en.md Outdated Show resolved Hide resolved
wiki/Beatmap_Discussion/en.md Outdated Show resolved Hide resolved
wiki/Beatmap_Discussion/en.md Outdated Show resolved Hide resolved
wiki/Beatmap_Discussion/en.md Outdated Show resolved Hide resolved
wiki/Beatmap_Discussion/en.md Outdated Show resolved Hide resolved
wiki/Beatmap_Discussion/en.md Outdated Show resolved Hide resolved
wiki/Beatmap_Discussion/en.md Outdated Show resolved Hide resolved
wiki/Beatmap_Discussion/en.md Outdated Show resolved Hide resolved
wiki/Beatmap_Discussion/en.md Outdated Show resolved Hide resolved
@Pennek Pennek requested a review from MegaApplePi February 17, 2020 22:16
@Pennek Pennek changed the title Rewrite Beatmap Discussion Rewrite Beatmap Discussion article Feb 17, 2020
MegaApplePi
MegaApplePi previously approved these changes Apr 4, 2020
Copy link
Contributor

@MegaApplePi MegaApplePi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge tomorrow, if no other comments are made

@MegaApplePi MegaApplePi merged commit 9cc848f into ppy:master Apr 5, 2020
@Loctav Loctav mentioned this pull request Apr 5, 2020
24 tasks
@Pennek Pennek deleted the beatmap_discussion branch July 4, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants