-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test multiqc #439
base: main
Are you sure you want to change the base?
Test multiqc #439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, you have a really clean testing style :) Added some suggestions about restructuring a few tests, advice on mock usage and some other minor nitpicks.
Reviewed feedback and implemented changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…months ago (PR here: #533) where multiqc output was being overwritten by subsequent batch runs and so it was changed to be the hash of input files as prefix to filenames so that each multiqc report is specific to a batch being run and separate batches dont overwrite previous multiqc files.
No description provided.