Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always call next() on both tokenizers, to make sure both r1 and r2 files are read to the end #1

Merged
merged 2 commits into from
May 14, 2023

Conversation

lgruen
Copy link

@lgruen lgruen commented May 13, 2023

Fixes Illumina#41.

@lgruen lgruen requested a review from cassimons May 13, 2023 00:56
Copy link

@cassimons cassimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me

@lgruen lgruen merged commit 4f98e00 into master May 14, 2023
@lgruen lgruen deleted the tokenizer-next branch May 14, 2023 03:35
lgruen added a commit that referenced this pull request May 14, 2023
…les are read to the end (#1)

* Tokenizer.next() fix for Illumina#41

* Also fix alignDualFastq
@lgruen
Copy link
Author

lgruen commented May 14, 2023

Corresponding upstream PR: Illumina#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion inputR1.eof() failed [new]
2 participants