-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rust): properly read/write fixed-sized lists from/to parquet files #16747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
force-pushed
the
fix-parquet-write
branch
11 times, most recently
from
June 12, 2024 12:16
441f416
to
794932b
Compare
coastalwhite
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
June 12, 2024 12:16
coastalwhite
force-pushed
the
fix-parquet-write
branch
5 times, most recently
from
June 12, 2024 12:44
ac9a541
to
2a91e1c
Compare
This PR rewrites many of the parts that relate to Parquet reading and writing of nested fields. This PR is quite large, and I tried my best to extensively test the new implementation, but I am also confident that there are still bugs in it. My view at the moment that these bugs are fringe enough for the moment. Specifically, this PR merges the `RepLevelIter` and `DefLevelIter` into a `BufferedDremelIter` that properly follows the Parquet specification when it comes to *repetition* and *definition* levels. It is also buffered and thus should be faster (although I don't have numbers to back this up). For the reader side, most of the code is adjusted to skip add elements that are implied by invalid higher-level nestings. This PR also does many, many drive-by refactors in the Parquet code. Fixes pola-rs#16608.
coastalwhite
force-pushed
the
fix-parquet-write
branch
from
June 12, 2024 12:45
2a91e1c
to
4829f54
Compare
ritchie46
reviewed
Jun 12, 2024
ritchie46
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites many of the parts that relate to Parquet reading and writing of nested fields. This PR is quite large, and I tried my best to extensively test the new implementation, but I am also confident that there are still bugs in it. My view at the moment that these bugs are fringe enough for the moment.
Specifically, this PR merges the
RepLevelIter
andDefLevelIter
into aBufferedDremelIter
that properly follows the Parquet specification when it comes to repetition and definition levels. It is also buffered and thus should be faster (although I don't have numbers to back this up). For the reader side, most of the code is adjusted to skip add elements that are implied by invalid higher-level nestings.This PR also does many, many drive-by refactors in the Parquet code.
Fixes #16608.