Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Follow-up changes to polars-parquet #16949

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

coastalwhite
Copy link
Collaborator

This provides some small follow-up changes for #16747.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 69.76744% with 26 lines in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (d00ed0c) to head (f91cce7).

Files Patch % Lines
crates/polars-utils/src/fixedringbuffer.rs 31.42% 24 Missing ⚠️
...parquet/src/arrow/read/deserialize/nested_utils.rs 96.07% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16949      +/-   ##
==========================================
- Coverage   80.97%   80.96%   -0.02%     
==========================================
  Files        1445     1445              
  Lines      189825   189849      +24     
  Branches     2712     2712              
==========================================
- Hits       153717   153715       -2     
- Misses      35608    35634      +26     
  Partials      500      500              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jun 14, 2024

CodSpeed Performance Report

Merging #16949 will improve performances by 20.01%

Comparing coastalwhite:parquet-followup-changes (f91cce7) with main (d00ed0c)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main coastalwhite:parquet-followup-changes Change
test_groupby_h2oai_q5 2.3 ms 1.9 ms +20.01%

@ritchie46 ritchie46 changed the title refactor(rust): Follow-up changes to polar-parquet refactor(rust): Follow-up changes to polars-parquet Jun 14, 2024
@ritchie46 ritchie46 merged commit 4b88b32 into pola-rs:main Jun 14, 2024
23 checks passed
@coastalwhite coastalwhite deleted the parquet-followup-changes branch June 14, 2024 08:53
@c-peters c-peters added the accepted Ready for implementation label Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants