Assemble 1.21.30 #6453
Merged
Assemble 1.21.30 #6453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
IvanCraft623
requested changes
Sep 19, 2024
dktapps
reviewed
Sep 19, 2024
src/data/bedrock/block/convert/BlockStateToObjectDeserializer.php
Outdated
Show resolved
Hide resolved
dktapps
reviewed
Sep 19, 2024
src/network/mcpe/NetworkSession.php
Outdated
| $this->tryDisconnect(function() use ($ip, $port, $reason) : void{ | ||
| $this->sendDataPacket(TransferPacket::create($ip, $port), true); | ||
| $this->tryDisconnect(function() use ($ip, $port, $reason, $reloadWorld) : void{ | ||
| $this->sendDataPacket(TransferPacket::create($ip, $port, $reloadWorld), true); |
There was a problem hiding this comment.
As far as I know it just bricks hard transfers whenever it's true. No clue what it's supposed to do
dktapps
reviewed
Sep 19, 2024
Seems to be irrelevant for the client, we cannot risk rebroadcasting random values received
|
hello, how to have pocketmine mp to the newest version? |
Client is not being transferred in case of `true`, maybe it's expects something else after `TransferPacket`...
IvanCraft623
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR updates PM5 to 1.21.30
Changes
Backwards compatibility
See pmmp/BedrockProtocol#270