-
-
Notifications
You must be signed in to change notification settings - Fork 10
Logbook
current ticket: #45
I read documentation about i18ndude and translating string in general. For better understanding, I compared few packages such as this. Earlier today, I focussed on understanding buildout and fixing the previous PR.
current ticket: #290
I came back from Hackathon. There was few request change on the previous PR(#290).
I searched for various filters that could substitute the need of to_boolean but didn't find any.
I tried using default filter from jinja2 but that didn't work.
I'm stuck at #290.
current ticket: #290, #292
We(Maik and I) concluded to use a custom filter and make a wrapper for to_bolean method and add unittest for this method and well as skeleton test to test new filter. Created a new issue for this and made changes in the same branch as for #290. Made sufficient changes in the templates as well.
I finished that work and started to work on the previously assigned ticket (#45).
current ticket: #45
I read about MessageFactory and i18ndude which includes commands like rebuild, sync, merge etc. Then after the meeting, I made another PR with changes in CHANGES.rst and little note in base.py about filters.
current ticket: #45
Added command in buildout.cfg of addon and debug changes in .pot file.
As the second command i18ndude sync --pot {{{ package.dottedname }}}.pot */LC_MESSAGES/{{{ package.dottedname }}}.po; gives back warning as there is no file and no directory while running plonecli build. So I thought to add at least en/LC_MESSAGE/{{{ package.dottedname }}}.po in the bobtemplates.plone. And this will not throw any errors/Warnings. Then I started to add BrowserView in that package to verify if the current setup works or not.
current ticket: #45
I'm currently working on adding BrowserView to see if the current setup works. And I finished with german translation. You can see it here. And you can see the BrowserView at http://localhost:8080/Plone2/@@translate after choosing German language and for English, it's there at http://localhost:8080/Plone/@@translate. I understood the workflow. Though I went for manual translation because msginit is not installed on my system and didn't find a working way to install it on macos.
current ticket: #45, #22
Pushed my code #294. Started to work on #22 for a while as I think other works on #45 need little discussion.
current ticket: #22
Pushed my code #295 on another issue. I'm not confirm if it's not the correct way to go. So I didn't add tests for this.
current ticket: #22
Added plonecli config command to plonecli.
current ticket: #22, #212
Add config command to plonecli with default value as previous settings in the mrbob config. Shifted changes in .gitignore and buildout template to addon from buildout.
current ticket: #45, #280
Made few changes in translate.pt in collective.todo package. And started to work on adding view subtemplate.
current ticket: #45, #280
Pushed changes in the collective.todo and worked on adding questions on view subtemplate.
current ticket: #45, #280
Made preliminary subtemplate for the view and adding hooks.
current ticket: #280
I was stuck with that problem the whole day and didn't realize this was due to init.py in the view subtemplate. Then I changed the subtemplate structure and made few tweaks in the configure.zcml and tested the view. And then pushed the code.
current ticket: #280
Fixed lint errors and I noticed one problem as in configure.zcml when we add more view templates, then the previous changes get removed. So I used configure.zcml.example file to fix this issue.
current ticket: #45
Added my code to update_locale in collective.todo for experimentation.
current ticket: #45, #22, #280
My laptop got new SSD (older one had issues), so installing all these took time. I was stuck with macOS version of Python2.7.15 as had few issues in installing brew's one. Got stuck with few random problems which were not even there when I was working on the same code before swapping the new SSD. Finally installed brew's Python and all those problems disappeared. Fixed the #45 and #22 with all suggested changes. And in #280 added few questions in view subtemplate and removed unnecessary ones with skip question hooks.
current ticket: #280
Added questions with their edge cases in the template and python class. Added unittests, skeleton tests and subtemplate with all suggested changes. The test from skeleton tests will give some error because I need to fix tests of view in the generated package.
current ticket: #281
Learned about creating viewlet and managing it in a viewletmanager. Tried to create a package without view to see if viewlet can exist without a view. Added initial files structure in bobtemplates.plone.
current ticket: #281
Removed viewlet manager and unnecessary things. Viewlet was working fine in collective.myviewlets. Added the viewlet subtemplate in bobtemplates.plone in the PR. This is in progress as I need to add tests.
current ticket: #281
Added package and skeleton tests. Fix browser layer name and other small improvements (fix) in the subtemplate.
current ticket: #130
Read documentation on portlet. Started to implemented in a package. I'm using zope.formlib and using docs of plone 4, as it have much better guide for beginner.
current ticket: #130
Pushed working portlet at https://github.com/kakshay21/collective.myportlets. I followed Plone 4 docs and removed zope.formlib with z3c.form.
current ticket: #280
Worked on __call__ method of view to have UI element even in the case when we just have python class. Explored documentation to find a workaround for this. Tried to render it with just raw string to have Plone UI but failed. Tried to load a remote template in the runtime but after using it felt like not useful at all as it creates the template file which we don't want. So in the end, decided to just a raw string without any Plone UI in the case when only Python class is used and no template.
current ticket: #280
Made changes in view template and in the python class as mentioned in the review. Add tests to validate template, python file names. Add tests in the package to test the view's output.
current ticket: #280
Add the same changes in viewlet and added tests. While adding viewlet test in the generated package I felt that we need to have viewlet manager in order to check for viewlets inside it. But we can use the existing ones as of right now we're using an existing viewlet manager.
current ticket: #280
From the meeting discussion, I added the dynamic name in the delete files, shifted tests in the integration test and fixed package test for this.
current ticket: #280
I searched everywhere to find about configuration to bind a view to a specific folder. I searched through every package to get right configuration replacement of the wildcard (for="*"). Then I learned to create folder using structure in profile/defaults.
current ticket: #280
When I didn't get the right configuration to bind the view to a specific folder, I thought to make a logic in the view itself. Then I implemented the same in the view subtemplate.
current ticket: #280
And then I added tests for the correct folder and also for the wrong folder to check that view is not rendered in that folder. I was stuck in adding tests for the wrong folder as I thought to use "NotFound" exception from urllib2. But @enclope suggested the right one and learned to use grep.
...